RCFilters: Always use the filled bookmark icon (unClip)

Bug: T168828
Change-Id: I436f00bc87db143116125a185abd8000132df195

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 3f920f0..1a68b49 100644 (file)
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -24,7 +24,7 @@
                // Parent
                mw.rcfilters.ui.SaveFiltersPopupButtonWidget.parent.call( this, $.extend( {
                        framed: false,
                // Parent
                mw.rcfilters.ui.SaveFiltersPopupButtonWidget.parent.call( this, $.extend( {
                        framed: false,

-                       icon: 'clip',
+                       icon: 'unClip',

                        $overlay: this.$overlay,
                        title: mw.msg( 'rcfilters-savedqueries-add-new-title' ),
                        popup: {
                        $overlay: this.$overlay,
                        title: mw.msg( 'rcfilters-savedqueries-add-new-title' ),
                        popup: {


@@ -36,7 +36,7 @@
                        }
                }, config ) );
                // // HACK: Add an icon to the popup head label
                        }
                }, config ) );
                // // HACK: Add an icon to the popup head label

-               this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'clip' } ) ).$element );
+               this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'unClip' } ) ).$element );

 
                this.input = new OO.ui.TextInputWidget( {
                        validate: /\S/
 
                this.input = new OO.ui.TextInputWidget( {
                        validate: /\S/


@@ -109,15 +109,6 @@
                }
        };
 
                }
        };
 

-       /**
-        * Respond to popup toggle event
-        *
-        * @param {boolean} isVisible Popup is visible
-        */
-       mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onPopupToggle = function ( isVisible ) {
-               this.setIcon( isVisible ? 'unClip' : 'clip' );
-       };
-

        /**
         * Respond to popup ready event
         */
        /**
         * Respond to popup ready event
         */