Removed extra "tries" increment in the redis job queue
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 14 Oct 2014 21:58:26 +0000 (14:58 -0700)
committerOri.livneh <ori@wikimedia.org>
Mon, 20 Oct 2014 21:00:31 +0000 (21:00 +0000)
* This could result in jobs getting one less extra tries than they should

Change-Id: Ia2e82ca0965f6ce9e1354820eb03f40f047a949c

includes/jobqueue/JobQueueRedis.php

index b87c678..e6724f7 100644 (file)
@@ -614,7 +614,6 @@ LUA;
                                if attempts < ARGV[3] then
                                        -- Claim expired and retries left: re-enqueue the job
                                        redis.call('lPush',kUnclaimed,id)
-                                       redis.call('hIncrBy',kAttempts,id,1)
                                        released = released + 1
                                else
                                        -- Claim expired and no retries left: mark the job as dead