RC Filters: always join with 'page'
authorStephane Bisson <sbisson@wikimedia.org>
Wed, 3 May 2017 18:58:22 +0000 (14:58 -0400)
committerStephane Bisson <sbisson@wikimedia.org>
Wed, 3 May 2017 21:05:50 +0000 (17:05 -0400)
The 'last revision' filter group relies on
the 'page' table to filter and highlight.

Bug: T163561
Change-Id: I29be21596ce02270859936203c921777c952e3a4

includes/specials/SpecialRecentchanges.php

index aaa99b6..e143509 100644 (file)
@@ -247,11 +247,10 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
                        ] ];
                }
 
-               if ( $user->isAllowed( 'rollback' ) ) {
-                       $tables[] = 'page';
-                       $fields[] = 'page_latest';
-                       $join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ];
-               }
+               // JOIN on page, used for 'last revision' filter highlight
+               $tables[] = 'page';
+               $fields[] = 'page_latest';
+               $join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ];
 
                ChangeTags::modifyDisplayQuery(
                        $tables,