RCFilters UI: Don't remove removed saved links twice

The second removal also didn't remove the right thing.

Change-Id: Iab32ae2e19e2b19995b88fbfd2e84a36dbda1bac

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
index 9ae1d34..40186aa 100644 (file)
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
@@ -86,7 +86,6 @@
         */
        mw.rcfilters.ui.SavedLinksListWidget.prototype.onMenuItemRemove = function ( item ) {
                this.controller.removeSavedQuery( item.getID() );
-               this.menu.removeItems( [ item ] );
        };
 
        /**
@@ -131,7 +130,7 @@
         * @param {mw.rcfilters.ui.SavedLinksListItemWidget} item Menu item
         */
        mw.rcfilters.ui.SavedLinksListWidget.prototype.onModelRemoveItem = function ( item ) {
-               this.menu.removeItems( [ this.model.getItemByID( item.getID() ) ] );
+               this.menu.removeItems( [ this.menu.getItemFromData( item.getID() ) ] );
                this.button.toggle( !this.menu.isEmpty() );
        };
 }( mediaWiki ) );