[MCR] Fix RevisionInsertComplete Revision pass by reference

This was broken in:
6af796f3e0cf3e66cd7d7e59af8445f5712d68fe
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
https://gerrit.wikimedia.org/r/#/c/399174/7

Bug: T183503
Change-Id: I674493507ca4aa6677a3bab7a01d6dc3c2cdbc5b

diff --git a/includes/Revision.php b/includes/Revision.php
index ea73a61..c7c708e 100644 (file)
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -979,8 +979,10 @@ class Revision implements IDBAccessObject {
 
                $this->mRecord = $rec;
 
+               // Avoid PHP 7.1 warning of passing $this by reference
+               $revision = $this;
                // TODO: hard-deprecate in 1.32 (or even 1.31?)
-               Hooks::run( 'RevisionInsertComplete', [ $this, null, null ] );
+               Hooks::run( 'RevisionInsertComplete', [ &$revision, null, null ] );
 
                return $rec->getId();
        }