Cleanup JobQueueDB::recycleAndDeleteStaleJobs() use of IDatabase::affectedRows()
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 31 Jul 2019 02:22:43 +0000 (22:22 -0400)
committerMobrovac <mobrovac@wikimedia.org>
Thu, 8 Aug 2019 10:59:26 +0000 (10:59 +0000)
Bug: T229456
Change-Id: Ie22085ddba66f122e59e93baaf9b53c76b5ce448

includes/jobqueue/JobQueueDB.php

index f7b8ed2..d449e8a 100644 (file)
@@ -690,9 +690,9 @@ class JobQueueDB extends JobQueue {
                                        $dbw->update( 'job',
                                                [
                                                        'job_token' => '',
-                                                       'job_token_timestamp' => $dbw->timestamp( $now ) ], // time of release
-                                               [
-                                                       'job_id' => $ids ],
+                                                       'job_token_timestamp' => $dbw->timestamp( $now ) // time of release
+                                               ],
+                                               [ 'job_id' => $ids, "job_token != ''" ],
                                                __METHOD__
                                        );
                                        $affected = $dbw->affectedRows();