resourceloader: Remove warning for handled localStorage error
authorTimo Tijhof <krinklemail@gmail.com>
Sun, 3 Mar 2019 18:11:08 +0000 (18:11 +0000)
committerTimo Tijhof <krinklemail@gmail.com>
Sun, 3 Mar 2019 18:11:08 +0000 (18:11 +0000)
Leads to more confusion that actual utility in practice.
The storage being disabled is an entirely supported and expected
scenario, which we handle gracefully.

When wanting to ad-hoc check whether localStorage is enabled,
browsers tend to show that in their interface already (e.g. to
the side of the address bar in Chrome). And it can also be
trivially checked from the console by looking at localStorage
or mw.loader.store.

Bug: T195647
Change-Id: I1edf89e52ec56b4919816878924f096d5b7f7751

resources/src/startup/mediawiki.js

index 65cf316..c08d259 100644 (file)
                                                                return;
                                                        }
                                                } catch ( e ) {
-                                                       mw.trackError( 'resourceloader.exception', {
-                                                               exception: e,
-                                                               source: 'store-localstorage-init'
-                                                       } );
+                                                       // Perhaps localStorage was disabled by the user, or got corrupted.
+                                                       // See point 3 and 4 below. (T195647)
                                                }
 
                                                // If we get here, one of four things happened: