Merge "Article: Fix reference to view() in documentation comment"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 18 Sep 2018 02:26:10 +0000 (02:26 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 18 Sep 2018 02:26:10 +0000 (02:26 +0000)
1  2 
includes/page/Article.php

@@@ -355,7 -355,7 +355,7 @@@ class Article implements Page 
                                if ( $this->mRevision !== null ) {
                                        // Revision title doesn't match the page title given?
                                        if ( $this->mPage->getId() != $this->mRevision->getPage() ) {
 -                                              $function = get_class( $this->mPage ). '::newFromID';
 +                                              $function = get_class( $this->mPage ) . '::newFromID';
                                                $this->mPage = $function( $this->mRevision->getPage() );
                                        }
                                }
                // Note that the ArticleViewHeader hook is allowed to set $outputDone to a
                // ParserOutput instance.
                $pOutput = ( $outputDone instanceof ParserOutput )
 +                      // phpcs:ignore MediaWiki.Usage.NestedInlineTernary.UnparenthesizedTernary -- FIXME T203805
                        ? $outputDone // object fetched by hook
                        : $this->mParserOutput ?: null; // ParserOutput or null, avoid false
  
  
        /**
         * Lightweight method to get the parser output for a page, checking the parser cache
-        * and so on. Doesn't consider most of the stuff that WikiPage::view is forced to
+        * and so on. Doesn't consider most of the stuff that Article::view() is forced to
         * consider, so it's not appropriate to use there.
         *
         * @since 1.16 (r52326) for LiquidThreads
         * Call to WikiPage function for backwards compatibility.
         * @see WikiPage::doDeleteUpdates
         */
 -      public function doDeleteUpdates( $id, Content $content = null ) {
 -              return $this->mPage->doDeleteUpdates( $id, $content );
 +      public function doDeleteUpdates(
 +              $id,
 +              Content $content = null,
 +              $revision = null,
 +              User $user = null
 +      ) {
 +              $this->mPage->doDeleteUpdates( $id, $content, $revision, $user );
        }
  
        /**