postEdit: Use standard close icon
authorVolker E <volker.e@wikimedia.org>
Sat, 9 Sep 2017 05:47:22 +0000 (22:47 -0700)
committerVolker E <volker.e@wikimedia.org>
Sat, 9 Sep 2017 07:39:19 +0000 (00:39 -0700)
Making use of standard close icon and also prevent screenreaders
from reading 'x' if they ever come across the message.
Also slightly bumping `font-size` to better harmonize
with close icon and clean-up CSS.

Bug: T50067
Change-Id: I82cdad23462f62d5e8ab2eef8632a2b3ac35e93f

resources/src/mediawiki.action/images/close.png [new file with mode: 0644]
resources/src/mediawiki.action/images/close.svg [new file with mode: 0644]
resources/src/mediawiki.action/mediawiki.action.view.postEdit.less

diff --git a/resources/src/mediawiki.action/images/close.png b/resources/src/mediawiki.action/images/close.png
new file mode 100644 (file)
index 0000000..80dde95
Binary files /dev/null and b/resources/src/mediawiki.action/images/close.png differ
diff --git a/resources/src/mediawiki.action/images/close.svg b/resources/src/mediawiki.action/images/close.svg
new file mode 100644 (file)
index 0000000..7f75511
--- /dev/null
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20 20">
+       <path d="M3.636 2.222l14.142 14.142-1.414 1.414L2.222 3.636z"/>
+       <path d="M17.778 3.636L3.636 17.778l-1.414-1.414L16.364 2.222z"/>
+</svg>
index e1fa925..d19f098 100644 (file)
@@ -7,7 +7,7 @@
        height: 0;
        left: 50%;
        z-index: 1000;
-       font-size: 13px;
+       font-size: 14px;
        cursor: pointer;
 }
 
        opacity: 1;
        .transition( opacity 250ms );
 
+       &:after {
+               content: '';
+               background: no-repeat center center;
+               .background-image-svg( 'images/close.svg', 'images/close.png' );
+               background-size: 12px 12px;
+               position: absolute;
+               right: 0.4em;
+               top: 0;
+               bottom: 0;
+               min-width: 32px;
+               min-height: 32px;
+               opacity: 0.87;
+
+               &:hover {
+                       opacity: 1;
+               }
+       }
+
        &.mw-notification {
                padding-right: 3em;
        }
 }
 
 .postedit-icon {
-       padding-left: 41px; /* 25 + 8 + 8 */
+       padding-left: 25px;
        /* like min-height, but old IE compatible and keeps text vertically aligned, too */
        line-height: 25px;
        background-repeat: no-repeat;
-       background-position: 8px 50%;
 }
 
 .postedit-icon-checkmark {
        /* @embed */
        background-image: url( images/green-checkmark.png );
-       background-position: left;
-}
-
-.postedit:after {
-       content: '×';
-       position: absolute;
-       padding: 0 0.8em;
-       right: 0;
-       top: 0;
-       font-size: 1.25em;
-       font-weight: bold;
-       line-height: 2.3em;
-       text-shadow: 0 0.0625em 0 #fff;
-       opacity: 0.2;
-}
-
-.postedit:hover:after {
-       opacity: 0.4;
 }