Fix manual IN queries in checkStorage.php
authorPppery <mapreader@olum.org>
Thu, 14 Dec 2017 01:56:14 +0000 (20:56 -0500)
committerPppery <mapreader@olum.org>
Thu, 14 Dec 2017 02:01:17 +0000 (21:01 -0500)
Bug: T182689
Change-Id: Ifca7bd6d0385dd470cddc483f4641eeb2832580c

maintenance/storage/checkStorage.php

index 4071a06..6348e96 100644 (file)
@@ -208,7 +208,9 @@ class CheckStorage {
                                        $blobsTable = $this->dbStore->getTable( $extDb );
                                        $res = $extDb->select( $blobsTable,
                                                [ 'blob_id' ],
-                                               [ 'blob_id IN( ' . implode( ',', $blobIds ) . ')' ], __METHOD__ );
+                                               [ 'blob_id' => $blobIds ],
+                                               __METHOD__
+                                       );
                                        foreach ( $res as $row ) {
                                                unset( $xBlobIds[$row->blob_id] );
                                        }
@@ -410,7 +412,9 @@ class CheckStorage {
                        $headerLength = strlen( self::CONCAT_HEADER );
                        $res = $extDb->select( $blobsTable,
                                [ 'blob_id', "LEFT(blob_text, $headerLength) AS header" ],
-                               [ 'blob_id IN( ' . implode( ',', $blobIds ) . ')' ], __METHOD__ );
+                               [ 'blob_id' => $blobIds ],
+                               __METHOD__
+                       );
                        foreach ( $res as $row ) {
                                if ( strcasecmp( $row->header, self::CONCAT_HEADER ) ) {
                                        $this->addError(