jobqueue: Document Title as valid param type for compat (2)
authorTimo Tijhof <krinklemail@gmail.com>
Fri, 5 Apr 2019 00:09:30 +0000 (01:09 +0100)
committerTimo Tijhof <krinklemail@gmail.com>
Fri, 5 Apr 2019 16:02:11 +0000 (17:02 +0100)
Follows-up 9b4938c40d02c, and 4bff6f1558. The latter of which
updated ::factory() instead of __construct(). Oops.

This should fix build failures that are preventing merges
in repos where Phan is finding Job::__construct(string, Title)
where it currently fails as follows:

 CompileArticleMetadataJob.php:11
 PhanTypeMismatchArgument Argument 2 (params) is …\Title|string but
 \Job::__construct() takes array

As Phan is reading the php doc I guess.

Change-Id: I128d57ead6bcb9dbae99d41a1f23192c3f6fbdba

includes/jobqueue/Job.php

index 0b5e62d..55cb942 100644 (file)
@@ -106,7 +106,7 @@ abstract class Job implements IJobSpecification {
 
        /**
         * @param string $command
-        * @param array $params
+        * @param array|Title $params
         */
        public function __construct( $command, $params = [] ) {
                if ( $params instanceof Title ) {