Fix additional usage of incorrect case
authormainframe98 <k.s.werf@hotmail.com>
Fri, 15 Dec 2017 10:58:11 +0000 (11:58 +0100)
committermainframe98 <k.s.werf@hotmail.com>
Fri, 15 Dec 2017 10:58:11 +0000 (11:58 +0100)
Courtesy of the PhpStorm inspection Case mismatch in method call or
class usage.

Bug: T166759
Change-Id: I27c53658b99048fa0dd8f9d6ef1398620386e1cc

includes/AutoLoader.php
includes/changes/ChangesListFilter.php
includes/parser/ParserOutput.php
includes/registration/ExtensionRegistry.php
tests/phpunit/includes/Storage/RevisionStoreRecordTest.php
tests/phpunit/includes/jobqueue/JobTest.php
tests/phpunit/structure/ResourcesTest.php

index 675e347..52410fe 100644 (file)
@@ -133,5 +133,5 @@ class AutoLoader {
        }
 }
 
-Autoloader::$psr4Namespaces = AutoLoader::getAutoloadNamespaces();
+AutoLoader::$psr4Namespaces = AutoLoader::getAutoloadNamespaces();
 spl_autoload_register( [ 'AutoLoader', 'autoload' ] );
index 2546f2b..1c86d44 100644 (file)
@@ -468,7 +468,7 @@ abstract class ChangesListFilter {
         * @param FormOptions $opts
         * @return bool
         */
-       public function activelyInConflictWithFilter( ChangeslistFilter $filter, FormOptions $opts ) {
+       public function activelyInConflictWithFilter( ChangesListFilter $filter, FormOptions $opts ) {
                if ( $this->isSelected( $opts ) && $filter->isSelected( $opts ) ) {
                        /** @var ChangesListFilter $siblingFilter */
                        foreach ( $this->getSiblings() as $siblingFilter ) {
@@ -484,7 +484,7 @@ abstract class ChangesListFilter {
                return false;
        }
 
-       private function hasConflictWithFilter( ChangeslistFilter $filter ) {
+       private function hasConflictWithFilter( ChangesListFilter $filter ) {
                return in_array( $filter, $this->getConflictingFilters() );
        }
 
index ff9c28d..153a770 100644 (file)
@@ -596,7 +596,7 @@ class ParserOutput extends CacheTime {
 
                # Replace unnecessary URL escape codes with the referenced character
                # This prevents spammers from hiding links from the filters
-               $url = parser::normalizeLinkUrl( $url );
+               $url = Parser::normalizeLinkUrl( $url );
 
                $registerExternalLink = true;
                if ( !$wgRegisterInternalExternals ) {
index 994de97..6308461 100644 (file)
@@ -323,7 +323,7 @@ class ExtensionRegistry {
                }
 
                if ( isset( $info['autoloaderNS'] ) ) {
-                       Autoloader::$psr4Namespaces += $info['autoloaderNS'];
+                       AutoLoader::$psr4Namespaces += $info['autoloaderNS'];
                }
 
                foreach ( $info['defines'] as $name => $val ) {
index db85727..aa59a5b 100644 (file)
@@ -300,28 +300,28 @@ class RevisionStoreRecordTest extends MediaWikiTestCase {
 
        private function provideAudienceCheckData( $field ) {
                yield 'field accessible for oversighter (ALL)' => [
-                       Revisionrecord::SUPPRESSED_ALL,
+                       RevisionRecord::SUPPRESSED_ALL,
                        [ 'oversight' ],
                        true,
                        false
                ];
 
                yield 'field accessible for oversighter' => [
-                       Revisionrecord::DELETED_RESTRICTED | $field,
+                       RevisionRecord::DELETED_RESTRICTED | $field,
                        [ 'oversight' ],
                        true,
                        false
                ];
 
                yield 'field not accessible for sysops (ALL)' => [
-                       Revisionrecord::SUPPRESSED_ALL,
+                       RevisionRecord::SUPPRESSED_ALL,
                        [ 'sysop' ],
                        false,
                        false
                ];
 
                yield 'field not accessible for sysops' => [
-                       Revisionrecord::DELETED_RESTRICTED | $field,
+                       RevisionRecord::DELETED_RESTRICTED | $field,
                        [ 'sysop' ],
                        false,
                        false
@@ -342,9 +342,9 @@ class RevisionStoreRecordTest extends MediaWikiTestCase {
                ];
 
                yield 'unrelated field suppressed' => [
-                       $field === Revisionrecord::DELETED_COMMENT
-                               ? Revisionrecord::DELETED_USER
-                               : Revisionrecord::DELETED_COMMENT,
+                       $field === RevisionRecord::DELETED_COMMENT
+                               ? RevisionRecord::DELETED_USER
+                               : RevisionRecord::DELETED_COMMENT,
                        [ 'user' ],
                        true,
                        true
index e2aacae..395d12c 100644 (file)
@@ -101,7 +101,7 @@ class JobTest extends MediaWikiTestCase {
         * @covers Job::factory
         */
        public function testJobFactory( $handler ) {
-               $this->mergeMWGlobalArrayValue( 'wgJobClasses', [ 'testdummy' => $handler ] );
+               $this->mergeMwGlobalArrayValue( 'wgJobClasses', [ 'testdummy' => $handler ] );
 
                $job = Job::factory( 'testdummy', Title::newMainPage(), [] );
                $this->assertInstanceOf( NullJob::class, $job );
index d31779d..62ddace 100644 (file)
@@ -55,7 +55,7 @@ class ResourcesTest extends MediaWikiTestCase {
        public function testIllegalDependencies() {
                $data = self::getAllModules();
 
-               $illegalDeps = ResourceLoaderStartupModule::getStartupModules();
+               $illegalDeps = ResourceLoaderStartUpModule::getStartupModules();
                foreach ( $data['modules'] as $moduleName => $module ) {
                        if ( $module->isRaw() ) {
                                $illegalDeps[] = $moduleName;