summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
8dfa5aa)
Instead, use assert.async(), or (in this case) return the Promise directly
to QUnit.test, which will naturally await it.
As bonus, it'll handle errors, too. (instead of timing out)
Change-Id: I94ee0bf72a3d8ac2e588cd75cbe0787b5001d5b4
- QUnit.asyncTest( 'toggleToc', function ( assert ) {
+ QUnit.test( 'toggleToc', function ( assert ) {
var tocHtml, $toc, $toggleLink, $tocList;
assert.strictEqual( $( '.toc' ).length, 0, 'There is no table of contents on the page at the beginning' );
var tocHtml, $toc, $toggleLink, $tocList;
assert.strictEqual( $( '.toc' ).length, 0, 'There is no table of contents on the page at the beginning' );
assert.strictEqual( $tocList.is( ':hidden' ), false, 'The table of contents is now visible' );
$toggleLink.click();
assert.strictEqual( $tocList.is( ':hidden' ), false, 'The table of contents is now visible' );
$toggleLink.click();
- $tocList.promise().done( function () {
+ return $tocList.promise().then( function () {
assert.strictEqual( $tocList.is( ':hidden' ), true, 'The table of contents is now hidden' );
$toggleLink.click();
assert.strictEqual( $tocList.is( ':hidden' ), true, 'The table of contents is now hidden' );
$toggleLink.click();
- $tocList.promise().done( function () {
- QUnit.start();
- } );
+ return $tocList.promise();
} );
} );
}( mediaWiki, jQuery ) );
} );
} );
}( mediaWiki, jQuery ) );