TitleTest: fix minor todo about test naming
authorChad Horohoe <chadh@wikimedia.org>
Thu, 28 Aug 2014 18:38:18 +0000 (11:38 -0700)
committerChad Horohoe <chadh@wikimedia.org>
Thu, 28 Aug 2014 18:38:18 +0000 (11:38 -0700)
Change-Id: I1aa29b859cb1dcf0ff3c30c23f5d4c6b412f72f9

tests/phpunit/includes/TitleTest.php

index d0f418b..b2b0d34 100644 (file)
@@ -222,11 +222,10 @@ class TitleTest extends MediaWikiTestCase {
        }
 
        /**
-        * @dataProvider provideBug31100
+        * @dataProvider provideSpecialNamesWithAndWithoutParameter
         * @covers Title::fixSpecialName
-        * @todo give this test a real name explaining what is being tested here
         */
-       public function testBug31100FixSpecialName( $text, $expectedParam ) {
+       public function testFixSpecialNameRetainsParameter( $text, $expectedParam ) {
                $title = Title::newFromText( $text );
                $fixed = $title->fixSpecialName();
                $stuff = explode( '/', $fixed->getDBkey(), 2 );
@@ -242,7 +241,7 @@ class TitleTest extends MediaWikiTestCase {
                );
        }
 
-       public static function provideBug31100() {
+       public static function provideSpecialNamesWithAndWithoutParameter() {
                return array(
                        array( 'Special:Version', null ),
                        array( 'Special:Version/', '' ),