Don't misname login button
authorBrad Jorsch <bjorsch@wikimedia.org>
Tue, 14 Jun 2016 13:42:15 +0000 (09:42 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Tue, 14 Jun 2016 14:07:23 +0000 (10:07 -0400)
Particularly don't name it "wpRemember", which is the name of a
completely different field.

Bug: T137799
Change-Id: I4b5f79ec59edf33b3ec91f019bf08ef5507ed55b

includes/specialpage/LoginSignupSpecialPage.php

index 3099a9b..eb1c805 100644 (file)
@@ -1025,6 +1025,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
                                'rememberMe' => [
                                        // option for saving the user token to a cookie
                                        'type' => 'check',
+                                       'name' => 'wpRemember',
                                        'label-message' => $this->msg( 'userlogin-remembermypassword' )
                                                ->numParams( $expirationDays ),
                                        'id' => 'wpRemember',
@@ -1032,7 +1033,6 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
                                'loginattempt' => [
                                        // submit button
                                        'type' => 'submit',
-                                       'name' => 'wpRemember',
                                        'default' => $this->msg( 'pt-login-' . $continuePart . 'button' )->text(),
                                        'id' => 'wpLoginAttempt',
                                        'weight' => 100,