mediawiki.Upload: Don't choke on nameless or dateless files
authorBartosz Dziewoński <matma.rex@gmail.com>
Tue, 20 Oct 2015 21:55:56 +0000 (23:55 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Tue, 20 Oct 2015 21:55:56 +0000 (23:55 +0200)
Bug: T116073
Change-Id: I5919f1457b019ebc913beeb458ee3c6290223cfe

resources/src/mediawiki/mediawiki.Upload.js

index 1432912..4f8789d 100644 (file)
         */
        UP.setFilenameFromFile = function () {
                var file = this.getFile();
+               if ( !file ) {
+                       return;
+               }
                if ( file.nodeType && file.nodeType === Node.ELEMENT_NODE ) {
                        // File input element, use getBasename to cut out the path
                        this.setFilename( this.getBasename( file.value ) );
-               } else if ( file.name && file.lastModified ) {
+               } else if ( file.name ) {
                        // HTML5 FileAPI File object, but use getBasename to be safe
                        this.setFilename( this.getBasename( file.name ) );
+               } else {
+                       // If we ever implement uploading files from clipboard, they might not have a name
+                       this.setFilename( '?' );
                }
        };