Fix various minor IDEA warnings in LoadBalancer

Change-Id: Ic65a04ca1b988fe36e088709d7dc4e981670cb62

diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 8601785..baab031 100644 (file)
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -441,12 +441,15 @@ class LoadBalancer implements ILoadBalancer {
 
        /**
         * @param int $i
-        * @return IDatabase
+        * @return IDatabase|bool
         */
        public function getAnyOpenConnection( $i ) {
                foreach ( $this->mConns as $connsByServer ) {
                        if ( !empty( $connsByServer[$i] ) ) {
-                               return reset( $connsByServer[$i] );
+                               /** @var $serverConns IDatabase[] */
+                               $serverConns = $connsByServer[$i];
+
+                               return reset( $serverConns );
                        }
                }