Minor followup to r70480

Only throw missingparam for string === '' when it is required

RELEASE-NOTES for breaking change

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 08bfc52..7755b79 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -350,7 +350,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 24330) Add &redirect parameter to ?action=edit 
 * (bug 24722) For list=allusers&auprop=blockinfo, only show blockedby and blockreason if 
   the user is actually blocked.
-* Add format=dump and format=dumpfm, outputs results in PHP's var_dump() format. 
+* Add format=dump and format=dumpfm, outputs results in PHP's var_dump() format
+* For required string parameters, if '' is provided, this is now classed as missing
 
 === Languages updated in 1.17 ===
 

diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index 93d57d6..29881e7 100644 (file)
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -664,7 +664,7 @@ abstract class ApiBase {
                                        case 'NULL': // nothing to do
                                                break;
                                        case 'string':
-                                               if ( $value === '' ) {
+                                               if ( $required && $value === '' ) {
                                                        $this->dieUsageMsg( array( 'missingparam', $paramName ) );
                                                }