Add logging for "Invalid message parameter"

Records a full stacktrace for this warning

Bug: 58676
Change-Id: I234b525b04168eee6085d44fbf0e0d8ac3d0af91

diff --git a/includes/Message.php b/includes/Message.php
index 6ac87b3..dd22844 100644 (file)
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -817,11 +817,12 @@ class Message {
                        } elseif ( isset( $param['bitrate'] ) ) {
                                return array( 'before', $this->language->formatBitrate( $param['bitrate'] ) );
                        } else {
-                               trigger_error(
-                                       'Invalid parameter for message "' . $this->getKey() . '": ' .
-                                       htmlspecialchars( serialize( $param ) ),
-                                       E_USER_WARNING
-                               );
+                               $warning = 'Invalid parameter for message "' . $this->getKey() . '": ' .
+                                       htmlspecialchars( serialize( $param ) );
+                               trigger_error( $warning, E_USER_WARNING );
+                               $e = new Exception;
+                               wfDebugLog( 'Bug58676', $warning . "\n" . $e->getTraceAsString() );
+
                                return array( 'before', '[INVALID]' );
                        }
                } elseif ( $param instanceof Message ) {