Remove superfluous cast to int
authorWMDE-Fisch <christoph.jauera@wikimedia.de>
Tue, 30 Apr 2019 14:37:03 +0000 (16:37 +0200)
committerWMDE-Fisch <christoph.jauera@wikimedia.de>
Tue, 30 Apr 2019 14:57:18 +0000 (14:57 +0000)
The return type from User:idFromName should now always be an int or
null.

Change-Id: Id89ada740a89d7958548673ad91397e18757bbc5
Depends-On: I3085d89b93db2b888c190ba193623b86dc93759a

maintenance/cleanupUsersWithNoId.php

index 61d1e5d..f7fd9d5 100644 (file)
@@ -166,13 +166,13 @@ class CleanupUsersWithNoId extends LoggedUpdateMaintenance {
 
                                $id = 0;
                                if ( $this->assign ) {
-                                       $id = (int)User::idFromName( $name );
+                                       $id = User::idFromName( $name );
                                        if ( !$id ) {
                                                // See if any extension wants to create it.
                                                if ( !isset( $this->triedCreations[$name] ) ) {
                                                        $this->triedCreations[$name] = true;
                                                        if ( !Hooks::run( 'ImportHandleUnknownUser', [ $name ] ) ) {
-                                                               $id = (int)User::idFromName( $name, User::READ_LATEST );
+                                                               $id = User::idFromName( $name, User::READ_LATEST );
                                                        }
                                                }
                                        }