SECURITY: Fix rebase error in 4d38a489
authorBrad Jorsch <bjorsch@wikimedia.org>
Tue, 14 Nov 2017 16:17:02 +0000 (11:17 -0500)
committerReedy <reedy@wikimedia.org>
Wed, 15 Nov 2017 03:21:54 +0000 (03:21 +0000)
The fix for T125177 from F4932228 was incorrectly rebased when it was
applied to master as 4d38a489, causing the bug to not actually be fixed.

Bug: T180488
Change-Id: Ie6b87ef2373369987c112c19903c99afb789c1ff

includes/api/ApiBase.php

index 80aeff5..bf2b977 100644 (file)
@@ -1069,10 +1069,10 @@ abstract class ApiBase extends ContextSource {
                        } else {
                                $type = 'NULL'; // allow everything
                        }
                        } else {
                                $type = 'NULL'; // allow everything
                        }
+               }
 
 
-                       if ( $type == 'password' || !empty( $paramSettings[self::PARAM_SENSITIVE] ) ) {
-                               $this->getMain()->markParamsSensitive( $encParamName );
-                       }
+               if ( $type == 'password' || !empty( $paramSettings[self::PARAM_SENSITIVE] ) ) {
+                       $this->getMain()->markParamsSensitive( $encParamName );
                }
 
                if ( $type == 'boolean' ) {
                }
 
                if ( $type == 'boolean' ) {