Phan: resolve and reenable PhanAccessMethodProtected

Change-Id: I2bd7c787012f4f54600f3289d9d0d725f87788bc

diff --git a/includes/Preferences.php b/includes/Preferences.php
index f08b155..f65b2ce 100644 (file)
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -303,6 +303,8 @@ class Preferences {
        /**
         * Handle the form submission if everything validated properly
         *
+        * @deprecated since 1.31, use PreferencesFactory
+        *
         * @param array $formData
         * @param PreferencesForm $form
         * @return bool|Status|string

diff --git a/includes/libs/filebackend/FileBackendMultiWrite.php b/includes/libs/filebackend/FileBackendMultiWrite.php
index f8ca7e5..9c367af 100644 (file)
--- a/includes/libs/filebackend/FileBackendMultiWrite.php
+++ b/includes/libs/filebackend/FileBackendMultiWrite.php
@@ -87,6 +87,9 @@ class FileBackendMultiWrite extends FileBackend {
         *                      This will apply such updates post-send for web requests. Note that
         *                      any checks from "syncChecks" are still synchronous.
         *
+        * Bogus warning
+        * @suppress PhanAccessMethodProtected
+        *
         * @param array $config
         * @throws FileBackendError
         */

diff --git a/includes/preferences/DefaultPreferencesFactory.php b/includes/preferences/DefaultPreferencesFactory.php
index 0391b30..a23d644 100644 (file)
--- a/includes/preferences/DefaultPreferencesFactory.php
+++ b/includes/preferences/DefaultPreferencesFactory.php
@@ -1617,7 +1617,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
         * @param PreferencesForm $form
         * @return bool|Status|string
         */
-       protected function legacySaveFormData( $formData, PreferencesForm $form ) {
+       public function legacySaveFormData( $formData, PreferencesForm $form ) {
                return $this->saveFormData( $formData, $form );
        }
 

diff --git a/tests/phan/config.php b/tests/phan/config.php
index 52a565c..84132b9 100644 (file)
--- a/tests/phan/config.php
+++ b/tests/phan/config.php
@@ -294,8 +294,6 @@ return [
         * to this black-list to inhibit them from being reported.
         */
        'suppress_issue_types' => [
-               // approximate error count: 1
-               "PhanAccessMethodProtected",
                // approximate error count: 29
                "PhanCommentParamOnEmptyParamList",
                // approximate error count: 33