Disables upload by url option for users without the necessary permissions

Does an explicit check for a true value in SpecialUpload::getSourceSection

Bug: 39507
Change-Id: I00297494230d07081dd85a810321446badc3ecb0

diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php
index 01c0aaf..976294b 100644 (file)
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -827,7 +827,7 @@ class UploadForm extends HTMLForm {
                }
 
                $canUploadByUrl = UploadFromUrl::isEnabled()
-                       && UploadFromUrl::isAllowed( $this->getUser() )
+                       && ( UploadFromUrl::isAllowed( $this->getUser() ) === true )
                        && $wgCopyUploadsFromSpecialUpload;
                $radio = $canUploadByUrl;
                $selectedSourceType = strtolower( $this->getRequest()->getText( 'wpSourceType', 'File' ) );