Allow all rc options in feeds
authorNiklas Laxström <niklas.laxstrom@gmail.com>
Thu, 22 Nov 2012 10:56:16 +0000 (10:56 +0000)
committerNiklas Laxström <niklas.laxstrom@gmail.com>
Thu, 22 Nov 2012 11:14:04 +0000 (11:14 +0000)
The comment seems outdated given the following code in ChangesFeed:
$optionsHash = md5( serialize( $opts->getAllValues() ) ) . $wgRenderHashAppend;

Change-Id: I6f7ac3badf14eef8d193053c4788d7d7f5eb03f3

includes/specials/SpecialRecentchanges.php

index f542640..14f9c8d 100644 (file)
@@ -109,8 +109,7 @@ class SpecialRecentChanges extends IncludableSpecialPage {
        public function feedSetup() {
                global $wgFeedLimit;
                $opts = $this->getDefaultOptions();
-               # Feed is cached on limit,hideminor,namespace; other params would randomly not work
-               $opts->fetchValuesFromRequest( $this->getRequest(), array( 'limit', 'hideminor', 'namespace' ) );
+               $opts->fetchValuesFromRequest( $this->getRequest() );
                $opts->validateIntBounds( 'limit', 0, $wgFeedLimit );
                return $opts;
        }