Fix "Undefined index: type" warning on LoginSignupSpecialPage
authorGergő Tisza <gtisza@wikimedia.org>
Fri, 10 Jun 2016 00:43:49 +0000 (00:43 +0000)
committerGergő Tisza <gtisza@wikimedia.org>
Fri, 10 Jun 2016 00:48:14 +0000 (00:48 +0000)
When discarding form descriptors that do not have an equivalent
AuthenticationRequest field, do not assume the descriptor always
has a type.

Th warning was probably caused by I2a8cd4850.

Change-Id: Id1daee1e4954199fcb2077178e8f08d1ad3ae916

includes/specialpage/LoginSignupSpecialPage.php

index d8f5e66..3099a9b 100644 (file)
@@ -854,7 +854,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
                                        !isset( $coreField['baseField'] )
                                        || !isset( $fieldInfo[$coreField['baseField']] )
                                ) && !in_array( $fieldName, $specialFields, true )
-                               && $coreField['type'] !== 'submit'
+                               && ( !isset( $coreField['type'] ) || $coreField['type'] !== 'submit' )
                        ) {
                                $coreFieldDescriptors[$fieldName] = null;
                                continue;