CSSMin: Add more edge cases with spaces to CSSMinTest
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Wed, 2 May 2018 10:30:01 +0000 (12:30 +0200)
committerKrinkle <krinklemail@gmail.com>
Wed, 2 May 2018 17:03:57 +0000 (17:03 +0000)
Change-Id: Id5e884711ab69615273dd050d83c65a385aaa817

tests/phpunit/includes/libs/CSSMinTest.php

index 46bf2c6..dabf66b 100644 (file)
@@ -316,6 +316,10 @@ class CSSMinTest extends MediaWikiTestCase {
                                [ 'background-image: url("");', false, '/example', false ],
                                'background-image: url("");',
                        ],
+                       'Single quote with outer spacing' => [
+                               [ "background-image: url( '' );", false, '/example', false ],
+                               "background-image: url( '' );",
+                       ],
                ];
        }
 
@@ -390,6 +394,11 @@ class CSSMinTest extends MediaWikiTestCase {
                                'foo { background: url(/static/foo.png?query=yes); }',
                                'foo { background: url(https://expand.example/static/foo.png?query=yes); }',
                        ],
+                       [
+                               'Path-relative URL with query',
+                               "foo { background: url(?query=yes); }",
+                               'foo { background: url(http://localhost/w/?query=yes); }',
+                       ],
                        [
                                'Remote URL (unnecessary quotes not preserved)',
                                'foo { background: url("http://example.org/w/unnecessary-quotes.png"); }',
@@ -534,6 +543,11 @@ class CSSMinTest extends MediaWikiTestCase {
                                'foo { background: url( "http://localhost/styles.css?quoted=double" ) }',
                                'foo { background: url(http://localhost/styles.css?quoted=double) }',
                        ],
+                       [
+                               'Background URL (single quoted, containing spaces, with outer spacing)',
+                               "foo { background: url( ' red.gif ' ); }",
+                               'foo { background: url("http://localhost/w/ red.gif "); }',
+                       ],
                        [
                                'Simple case with comments before url',
                                'foo { prop: /* some {funny;} comment */ url(bar.png); }',