Reduce deadlocks adding log rows to the RC table on delete

bug: 56776
Change-Id: Ic75530b25f3fa5668019c76ce59a1dda2768f389

diff --git a/includes/WikiPage.php b/includes/WikiPage.php
index 52c5ccc..cedbcf9 100644 (file)
--- a/includes/WikiPage.php
+++ b/includes/WikiPage.php
@@ -2874,7 +2874,11 @@ class WikiPage implements Page, IDBAccessObject {
                $logEntry->setTarget( $logTitle );
                $logEntry->setComment( $reason );
                $logid = $logEntry->insert();
-               $logEntry->publish( $logid );
+
+               $dbw->onTransactionPreCommitOrIdle( function() use ( $dbw, $logEntry, $logid ) {
+                       // Bug 56776: avoid deadlocks (especially from FileDeleteForm)
+                       $logEntry->publish( $logid );
+               } );
 
                if ( $commit ) {
                        $dbw->commit( __METHOD__ );