Set mCache in the second MessageCache::loadFromDatabase() caller
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 2 Feb 2017 22:06:33 +0000 (14:06 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 2 Feb 2017 22:06:33 +0000 (14:06 -0800)
The member variable is needed in the next lines, which previously
just used the array with "LATEST" set and would be seen as invalid
and discarded next time.

Bug: T157033
Change-Id: I5b84b1ae4a9c7b710ee452c61d7d9d6076ec9e6a

includes/cache/MessageCache.php

index 9bf0840..4facc20 100644 (file)
@@ -584,7 +584,8 @@ class MessageCache {
                                        return;
                                }
                                // Load the messages from the master DB to avoid race conditions
-                               $this->loadFromDB( $code, self::FOR_UPDATE );
+                               $cache = $this->loadFromDB( $code, self::FOR_UPDATE );
+                               $this->mCache[$code] = $cache;
                                // Load the process cache values and set the per-title cache keys
                                $page = WikiPage::factory( Title::makeTitle( NS_MEDIAWIKI, $title ) );
                                $page->loadPageData( $page::READ_LATEST );