Add ->text() to prevent double HTML escaping
authorFomafix <fomafix@googlemail.com>
Fri, 30 Dec 2016 15:01:03 +0000 (16:01 +0100)
committerFomafix <fomafix@googlemail.com>
Fri, 30 Dec 2016 15:01:03 +0000 (16:01 +0100)
wfMessage() without ->text() makes an automatic HTML escaping.
Html::element() makes also a HTML escaping of the content.
This leads to a double escaping and raw HTML in shown on the rendered page.

Change-Id: I68165492c828837f842e7885f557644ca1bb0a8c

includes/specials/SpecialChangeCredentials.php

index ff70848..f22d5f3 100644 (file)
@@ -135,9 +135,9 @@ class SpecialChangeCredentials extends AuthManagerSpecialPage {
 
                $form->addPreText(
                        Html::openElement( 'dl' )
-                       . Html::element( 'dt', [], wfMessage( 'credentialsform-provider' ) )
+                       . Html::element( 'dt', [], wfMessage( 'credentialsform-provider' )->text() )
                        . Html::element( 'dd', [], $info['provider'] )
-                       . Html::element( 'dt', [], wfMessage( 'credentialsform-account' ) )
+                       . Html::element( 'dt', [], wfMessage( 'credentialsform-account' )->text() )
                        . Html::element( 'dd', [], $info['account'] )
                        . Html::closeElement( 'dl' )
                );