Deprecate WikiRevision::$user

This was introduced in 436a028086fb3f01c4605c5ad2964d56f9306aca
but was not used there.
It also currently looks unused.

We could go ahead and just remove this now, as anything that wants
to set the $user when the property is removed would still succeed.
But lets adhere to the deprecation policy here.

Change-Id: Id47323bb1ff480a16b46107825ed5f2f861ad976

diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index 04f5578..2380e9f 100644 (file)
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -266,6 +266,7 @@ changes to languages because of Phabricator reports.
 * The 'jquery.autoEllipsis' ResourceLoader module is now deprecated.
 * WikiRevision::$fileIsTemp was deprecated.
 * WikiRevision::$importer was deprecated.
+* WikiRevision::$user was deprecated.
 
 == Compatibility ==
 

diff --git a/includes/import/WikiRevision.php b/includes/import/WikiRevision.php
index 4b76394..df71524 100644 (file)
--- a/includes/import/WikiRevision.php
+++ b/includes/import/WikiRevision.php
@@ -50,7 +50,9 @@ class WikiRevision {
 
        /**
         * @var int
-        * @todo Can't find any uses. Public, because that's suspicious. Get clarity. */
+        * @deprecated in 1.29. Unused.
+        * @note Introduced in 436a028086fb3f01c4605c5ad2964d56f9306aca, unused there, unused now.
+        */
        public $user = 0;
 
        /** @var string */