Add whether user is elevated to unsafe js load log
authorBrian Wolff <bawolff+wn@gmail.com>
Tue, 15 May 2018 04:14:37 +0000 (04:14 +0000)
committerBrian Wolff <bawolff+wn@gmail.com>
Tue, 15 May 2018 04:38:48 +0000 (04:38 +0000)
To better triage the log entries.

Change-Id: Idf6d967d06b118ebd7b4d848e12bb36faf55a1b6

includes/actions/RawAction.php

index 159e708..50eb28a 100644 (file)
@@ -109,13 +109,16 @@ class RawAction extends FormlessAction {
                        $rootPage = strtok( $title->getText(), '/' );
                        $userFromTitle = User::newFromName( $rootPage, 'usable' );
                        if ( !$userFromTitle || $userFromTitle->getId() === 0 ) {
+                               $elevated = $this->getUser()->isAllowed( 'editinterface' );
+                               $elevatedText = $elevated ? 'by elevated ' : '';
                                $log = LoggerFactory::getInstance( "security" );
                                $log->warning(
-                                       "Unsafe JS/CSS/Json load - {user} loaded {title} with {ctype}",
+                                       "Unsafe JS/CSS/Json $elevatedText" . "load - {user} loaded {title} with {ctype}",
                                        [
                                                'user' => $this->getUser()->getName(),
                                                'title' => $title->getPrefixedDBKey(),
                                                'ctype' => $contentType,
+                                               'elevated' => $elevated
                                        ]
                                );
                                $msg = wfMessage( 'unregistered-user-config' );