SpecialRecentchanges: Repair recentchangestext in content language
authorFomafix <fomafix@googlemail.com>
Thu, 13 Nov 2014 13:37:22 +0000 (13:37 +0000)
committer[[mw:User:Fomafix]] <gerritpatchuploader@gmail.com>
Thu, 13 Nov 2014 13:37:22 +0000 (13:37 +0000)
* Use getHtmlCode() instead of getCode() to generate a BCP 47 conform
  HTML lang attribute.
* Use <div> instead of <p> because the <p> gets rendered as

<p lang="en" dir="ltr"></p>
<p>Text</p>
<p></p>

and the <div> gets rendered as

<div lang="en" dir="ltr">
<p>Text</p>
</div>

* Set $lineStart = true

Change-Id: I62ce26ba550fb25bc2e770186cea3435374bb4e6

includes/specials/SpecialRecentchanges.php

index e6d8f1c..58b51b3 100644 (file)
@@ -440,11 +440,11 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
                $message = $this->msg( 'recentchangestext' )->inContentLanguage();
                if ( !$message->isDisabled() ) {
                        $this->getOutput()->addWikiText(
                $message = $this->msg( 'recentchangestext' )->inContentLanguage();
                if ( !$message->isDisabled() ) {
                        $this->getOutput()->addWikiText(
-                               Html::rawElement( 'p',
-                                       array( 'lang' => $wgContLang->getCode(), 'dir' => $wgContLang->getDir() ),
+                               Html::rawElement( 'div',
+                                       array( 'lang' => $wgContLang->getHtmlCode(), 'dir' => $wgContLang->getDir() ),
                                        "\n" . $message->plain() . "\n"
                                ),
                                        "\n" . $message->plain() . "\n"
                                ),
-                               /* $lineStart */ false,
+                               /* $lineStart */ true,
                                /* $interface */ false
                        );
                }
                                /* $interface */ false
                        );
                }