Fix typo in UploadFromUrlJob::initializeSessionData()
authorKevin Israel <pleasestand@live.com>
Wed, 26 Aug 2015 04:38:54 +0000 (00:38 -0400)
committerKevin Israel <pleasestand@live.com>
Wed, 26 Aug 2015 04:49:30 +0000 (00:49 -0400)
Behavior would change under PHP7, though neither the current behavior
nor the new behavior seem correct. Did not test, as the feature has
been broken anyway since r81612 / e942dc69fcc6.

https://github.com/facebook/hhvm/issues/5523#issuecomment-133132721

Change-Id: Iac1177fee05b6c721abe54b6a96c1652445a5c90

includes/jobqueue/jobs/UploadFromUrlJob.php

index a15d51e..ade4810 100644 (file)
@@ -166,11 +166,11 @@ class UploadFromUrlJob extends Job {
        }
 
        /**
-        * Initialize the session data. Sets the intial result to queued.
+        * Initialize the session data. Sets the initial result to queued.
         */
        public function initializeSessionData() {
                $session =& self::getSessionData( $this->params['sessionKey'] );
-               $$session['result'] = 'Queued';
+               $session['result'] = 'Queued';
        }
 
        /**