Avoid races on null revision insertion
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Jan 2016 21:50:18 +0000 (13:50 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Jan 2016 21:50:18 +0000 (13:50 -0800)
Bug: T51581
Change-Id: I7bfa9a4b20458e76ab3c4659e7041cd68aac13a4

includes/Revision.php

index 1d7ac72..9373e40 100644 (file)
@@ -1628,8 +1628,10 @@ class Revision implements IDBAccessObject {
                        array(
                                'page_id' => $pageId,
                                'page_latest=rev_id',
-                               ),
-                       __METHOD__ );
+                       ),
+                       __METHOD__,
+                       array( 'FOR UPDATE' ) // T51581
+               );
 
                if ( $current ) {
                        if ( !$user ) {