Mark constructors of IndexPager subclasses as public

I believe this is uncontroversial. The constructor or the top-level
base class is public. Subclasses are not even allowed to change that.
So what this patch effectively does is basically documentation, but it
does not change anything.

Change-Id: Icd5da81de284bc4bf382bfdfd33dab428f1fab09

diff --git a/includes/actions/HistoryAction.php b/includes/actions/HistoryAction.php
index 7d6b548..8309e67 100644 (file)
--- a/includes/actions/HistoryAction.php
+++ b/includes/actions/HistoryAction.php
@@ -415,7 +415,13 @@ class HistoryPager extends ReverseChronologicalPager {
         * @param string $tagFilter
         * @param array $conds
         */
         * @param string $tagFilter
         * @param array $conds
         */

-       function __construct( $historyPage, $year = '', $month = '', $tagFilter = '', $conds = [] ) {
+       public function __construct(
+               HistoryAction $historyPage,
+               $year = '',
+               $month = '',
+               $tagFilter = '',
+               array $conds = []
+       ) {

                parent::__construct( $historyPage->getContext() );
                $this->historyPage = $historyPage;
                $this->tagFilter = $tagFilter;
                parent::__construct( $historyPage->getContext() );
                $this->historyPage = $historyPage;
                $this->tagFilter = $tagFilter;

diff --git a/includes/specials/pagers/ActiveUsersPager.php b/includes/specials/pagers/ActiveUsersPager.php
index 552e92f..b2b7424 100644 (file)
--- a/includes/specials/pagers/ActiveUsersPager.php
+++ b/includes/specials/pagers/ActiveUsersPager.php
@@ -47,7 +47,7 @@ class ActiveUsersPager extends UsersPager {
         * @param IContextSource|null $context
         * @param FormOptions $opts
         */
         * @param IContextSource|null $context
         * @param FormOptions $opts
         */

-       function __construct( IContextSource $context = null, FormOptions $opts ) {
+       public function __construct( IContextSource $context = null, FormOptions $opts ) {

                parent::__construct( $context );
 
                $this->RCMaxAge = $this->getConfig()->get( 'ActiveUserDays' );
                parent::__construct( $context );
 
                $this->RCMaxAge = $this->getConfig()->get( 'ActiveUserDays' );

diff --git a/includes/specials/pagers/AllMessagesTablePager.php b/includes/specials/pagers/AllMessagesTablePager.php
index 6d5f64b..cbcff5a 100644 (file)
--- a/includes/specials/pagers/AllMessagesTablePager.php
+++ b/includes/specials/pagers/AllMessagesTablePager.php
@@ -44,7 +44,7 @@ class AllMessagesTablePager extends TablePager {
         */
        public $custom;
 
         */
        public $custom;
 

-       function __construct( $page, $conds, Language $langObj = null ) {
+       public function __construct( $page, $conds, Language $langObj = null ) {

                parent::__construct( $page->getContext() );
                $this->mIndexField = 'am_title';
                $this->mPage = $page;
                parent::__construct( $page->getContext() );
                $this->mIndexField = 'am_title';
                $this->mPage = $page;

diff --git a/includes/specials/pagers/BlockListPager.php b/includes/specials/pagers/BlockListPager.php
index 74ec6b5..3d8c71f 100644 (file)
--- a/includes/specials/pagers/BlockListPager.php
+++ b/includes/specials/pagers/BlockListPager.php
@@ -43,7 +43,7 @@ class BlockListPager extends TablePager {
         * @param SpecialPage $page
         * @param array $conds
         */
         * @param SpecialPage $page
         * @param array $conds
         */

-       function __construct( $page, $conds ) {
+       public function __construct( $page, $conds ) {

                $this->page = $page;
                $this->conds = $conds;
                $this->mDefaultDirection = IndexPager::DIR_DESCENDING;
                $this->page = $page;
                $this->conds = $conds;
                $this->mDefaultDirection = IndexPager::DIR_DESCENDING;

diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php
index 18da235..2fe232e 100644 (file)
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -50,7 +50,7 @@ class ContribsPager extends RangeChronologicalPager {
         */
        protected $templateParser;
 
         */
        protected $templateParser;
 

-       function __construct( IContextSource $context, array $options ) {
+       public function __construct( IContextSource $context, array $options ) {

                parent::__construct( $context );
 
                $msgs = [
                parent::__construct( $context );
 
                $msgs = [

diff --git a/includes/specials/pagers/DeletedContribsPager.php b/includes/specials/pagers/DeletedContribsPager.php
index ee7eb3e..5150ab9 100644 (file)
--- a/includes/specials/pagers/DeletedContribsPager.php
+++ b/includes/specials/pagers/DeletedContribsPager.php
@@ -40,7 +40,7 @@ class DeletedContribsPager extends IndexPager {
         */
        protected $mNavigationBar;
 
         */
        protected $mNavigationBar;
 

-       function __construct( IContextSource $context, $target, $namespace = false ) {
+       public function __construct( IContextSource $context, $target, $namespace = false ) {

                parent::__construct( $context );
                $msgs = [ 'deletionlog', 'undeleteviewlink', 'diff' ];
                foreach ( $msgs as $msg ) {
                parent::__construct( $context );
                $msgs = [ 'deletionlog', 'undeleteviewlink', 'diff' ];
                foreach ( $msgs as $msg ) {

diff --git a/includes/specials/pagers/ImageListPager.php b/includes/specials/pagers/ImageListPager.php
index 889ec1a..861011e 100644 (file)
--- a/includes/specials/pagers/ImageListPager.php
+++ b/includes/specials/pagers/ImageListPager.php
@@ -50,7 +50,7 @@ class ImageListPager extends TablePager {
 
        protected $mTableName = 'image';
 
 
        protected $mTableName = 'image';
 

-       function __construct( IContextSource $context, $userName = null, $search = '',
+       public function __construct( IContextSource $context, $userName = null, $search = '',

                $including = false, $showAll = false
        ) {
                $this->setContext( $context );
                $including = false, $showAll = false
        ) {
                $this->setContext( $context );

diff --git a/includes/specials/pagers/MergeHistoryPager.php b/includes/specials/pagers/MergeHistoryPager.php
index 6a8f7da..efe72c7 100644 (file)
--- a/includes/specials/pagers/MergeHistoryPager.php
+++ b/includes/specials/pagers/MergeHistoryPager.php
@@ -30,7 +30,7 @@ class MergeHistoryPager extends ReverseChronologicalPager {
        /** @var array */
        public $mConds;
 
        /** @var array */
        public $mConds;
 

-       function __construct( SpecialMergeHistory $form, $conds, Title $source, Title $dest ) {
+       public function __construct( SpecialMergeHistory $form, $conds, Title $source, Title $dest ) {

                $this->mForm = $form;
                $this->mConds = $conds;
                $this->title = $source;
                $this->mForm = $form;
                $this->mConds = $conds;
                $this->title = $source;

diff --git a/includes/specials/pagers/NewFilesPager.php b/includes/specials/pagers/NewFilesPager.php
index 6b7e4b8..6ed72db 100644 (file)
--- a/includes/specials/pagers/NewFilesPager.php
+++ b/includes/specials/pagers/NewFilesPager.php
@@ -40,7 +40,7 @@ class NewFilesPager extends RangeChronologicalPager {
         * @param IContextSource $context
         * @param FormOptions $opts
         */
         * @param IContextSource $context
         * @param FormOptions $opts
         */

-       function __construct( IContextSource $context, FormOptions $opts ) {
+       public function __construct( IContextSource $context, FormOptions $opts ) {

                parent::__construct( $context );
 
                $this->opts = $opts;
                parent::__construct( $context );
 
                $this->opts = $opts;

diff --git a/includes/specials/pagers/NewPagesPager.php b/includes/specials/pagers/NewPagesPager.php
index f16a5cb..2f51751 100644 (file)
--- a/includes/specials/pagers/NewPagesPager.php
+++ b/includes/specials/pagers/NewPagesPager.php
@@ -32,7 +32,7 @@ class NewPagesPager extends ReverseChronologicalPager {
         */
        protected $mForm;
 
         */
        protected $mForm;
 

-       function __construct( $form, FormOptions $opts ) {
+       public function __construct( $form, FormOptions $opts ) {

                parent::__construct( $form->getContext() );
                $this->mForm = $form;
                $this->opts = $opts;
                parent::__construct( $form->getContext() );
                $this->mForm = $form;
                $this->opts = $opts;

diff --git a/includes/specials/pagers/ProtectedPagesPager.php b/includes/specials/pagers/ProtectedPagesPager.php
index 3e97923..f457d2f 100644 (file)
--- a/includes/specials/pagers/ProtectedPagesPager.php
+++ b/includes/specials/pagers/ProtectedPagesPager.php
@@ -44,7 +44,7 @@ class ProtectedPagesPager extends TablePager {
         * @param bool $noredirect
         * @param LinkRenderer $linkRenderer
         */
         * @param bool $noredirect
         * @param LinkRenderer $linkRenderer
         */

-       function __construct( $form, $conds, $type, $level, $namespace,
+       public function __construct( $form, $conds, $type, $level, $namespace,

                $sizetype, $size, $indefonly, $cascadeonly, $noredirect,
                LinkRenderer $linkRenderer
        ) {
                $sizetype, $size, $indefonly, $cascadeonly, $noredirect,
                LinkRenderer $linkRenderer
        ) {

diff --git a/includes/specials/pagers/ProtectedTitlesPager.php b/includes/specials/pagers/ProtectedTitlesPager.php
index ed437be..bde3d98 100644 (file)
--- a/includes/specials/pagers/ProtectedTitlesPager.php
+++ b/includes/specials/pagers/ProtectedTitlesPager.php
@@ -26,7 +26,7 @@ class ProtectedTitlesPager extends AlphabeticPager {
 
        public $mForm, $mConds;
 
 
        public $mForm, $mConds;
 

-       function __construct( $form, $conds, $type, $level, $namespace,
+       public function __construct( $form, $conds, $type, $level, $namespace,

                $sizetype = '', $size = 0
        ) {
                $this->mForm = $form;
                $sizetype = '', $size = 0
        ) {
                $this->mForm = $form;

diff --git a/includes/specials/pagers/UsersPager.php b/includes/specials/pagers/UsersPager.php
index bc24d26..45b1a33 100644 (file)
--- a/includes/specials/pagers/UsersPager.php
+++ b/includes/specials/pagers/UsersPager.php
@@ -43,7 +43,7 @@ class UsersPager extends AlphabeticPager {
         * @param bool|null $including Whether this page is being transcluded in
         * another page
         */
         * @param bool|null $including Whether this page is being transcluded in
         * another page
         */

-       function __construct( IContextSource $context = null, $par = null, $including = null ) {
+       public function __construct( IContextSource $context = null, $par = null, $including = null ) {

                if ( $context ) {
                        $this->setContext( $context );
                }
                if ( $context ) {
                        $this->setContext( $context );
                }