ApiEmailUser: Add parentheses to fix output
authorBrad Jorsch <bjorsch@wikimedia.org>
Mon, 24 Jul 2017 19:47:17 +0000 (15:47 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Mon, 24 Jul 2017 19:47:17 +0000 (15:47 -0400)
Stupid PHP ternary operator being left-associative.

Bug: T171416
Change-Id: Iddcbe0d75d583e4021a3aab47be4a4912c492f03

includes/api/ApiEmailUser.php

index 72c7c35..4b4b76b 100644 (file)
@@ -71,7 +71,7 @@ class ApiEmailUser extends ApiBase {
                }
 
                $result = array_filter( [
-                       'result' => $retval->isGood() ? 'Success' : $retval->isOk() ? 'Warnings' : 'Failure',
+                       'result' => $retval->isGood() ? 'Success' : ( $retval->isOk() ? 'Warnings' : 'Failure' ),
                        'warnings' => $this->getErrorFormatter()->arrayFromStatus( $retval, 'warning' ),
                        'errors' => $this->getErrorFormatter()->arrayFromStatus( $retval, 'error' ),
                ] );