Do not block autopromote on partial blocks

Currently, a partial block will block an autopromote, this should not be the
case. Instead, autopromote will only be blocked by sitewide blocks.

Bug: T228479
Change-Id: Id945b6ab374cb49c4a265b5ca149e13b68d4acac

diff --git a/includes/Autopromote.php b/includes/Autopromote.php
index a413037..b17f1ab 100644 (file)
--- a/includes/Autopromote.php
+++ b/includes/Autopromote.php
@@ -198,8 +198,7 @@ class Autopromote {
                        case APCOND_IPINRANGE:
                                return IP::isInRange( $user->getRequest()->getIP(), $cond[1] );
                        case APCOND_BLOCKED:
-                               // @TODO Should partial blocks prevent auto promote?
-                               return (bool)$user->getBlock();
+                               return $user->getBlock() && $user->getBlock()->isSitewide();
                        case APCOND_ISBOT:
                                return in_array( 'bot', User::getGroupPermissions( $user->getGroups() ) );
                        default: