rdbms: make $wgSQLMode work as documented when it is NULL
authorAaron Schulz <aschulz@wikimedia.org>
Mon, 1 Apr 2019 21:39:36 +0000 (14:39 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Mon, 1 Apr 2019 21:52:48 +0000 (14:52 -0700)
NULL means that the SET query should not be sent.
This was broken since 5bc9b990acd0e0302f.

Change-Id: I148b1153ef6ecca99c56e4f63247820a766ae779

includes/libs/rdbms/database/DatabaseMysqlBase.php

index 7fccd57..36c947f 100644 (file)
@@ -106,7 +106,7 @@ abstract class DatabaseMysqlBase extends Database {
                                $this->$var = $params[$var];
                        }
                }
-               $this->sqlMode = $params['sqlMode'] ?? '';
+               $this->sqlMode = $params['sqlMode'] ?? null;
                $this->utf8Mode = !empty( $params['utf8Mode'] );
                $this->insertSelectIsSafe = isset( $params['insertSelectIsSafe'] )
                        ? (bool)$params['insertSelectIsSafe'] : null;