replaceSection() should replace entire content if the section id is the empty string.

diff --git a/includes/Content.php b/includes/Content.php
index 793e62b..41b7ac3 100644 (file)
--- a/includes/Content.php
+++ b/includes/Content.php
@@ -541,7 +541,9 @@ class WikitextContent extends TextContent {
                $oldtext = $this->getNativeData();
                $text = $with->getNativeData();
 
-               if ( $section == 'new' ) {
+               if ( $section === '' ) {
+                       return $with; #XXX: copy first?
+               } if ( $section == 'new' ) {
                        # Inserting a new section
                        $subject = $sectionTitle ? wfMsgForContent( 'newsectionheaderdefaultlevel', $sectionTitle ) . "\n\n" : '';
                        if ( wfRunHooks( 'PlaceNewSection', array( $this, $oldtext, $subject, &$text ) ) ) {

diff --git a/tests/phpunit/includes/WikitextContentTest.php b/tests/phpunit/includes/WikitextContentTest.php
index c570024..96eea7a 100644 (file)
--- a/tests/phpunit/includes/WikitextContentTest.php
+++ b/tests/phpunit/includes/WikitextContentTest.php
@@ -85,7 +85,7 @@ just a test"
                               "",
                               "No more",
                               null,
-                              trim( preg_replace( '/^Intro/sm', 'No more', WikitextContentTest::$sections ) )
+                              "No more"
                        ),
                        array( WikitextContentTest::$sections,
                               "2",