resourceloader: Re-enable testGetBlobCached() test case
authorTimo Tijhof <krinklemail@gmail.com>
Wed, 30 May 2018 22:09:40 +0000 (23:09 +0100)
committerKrinkle <krinklemail@gmail.com>
Tue, 5 Jun 2018 17:57:51 +0000 (17:57 +0000)
Unable to reproduce the failure locally with Quibble.

The failure never made sense to begin with, as the only thing I could
conclude after ruling out all other possibilities was that PHP was
somehow forgetting/losing a key in a plain array in HashBagOStuff.

Bug: T176097
Change-Id: Ia438d5a929d7bd5dccf09387980ba92207616db0

tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php

index 4d98773..fa4d804 100644 (file)
@@ -103,11 +103,6 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
                $this->assertEquals( '{"foo":"Example"}', $blob, 'Generated blob' );
        }
 
-       /**
-        * Seems to fail sometimes (T176097).
-        *
-        * @group Broken
-        */
        public function testGetBlobCached() {
                $module = $this->makeModule( [ 'example' ] );
                $rl = new ResourceLoader();