Downgrade 'found writes/callbacks pending.' from error to info
authorMukunda Modell <mmodell@wikimedia.org>
Mon, 26 Jun 2017 16:27:23 +0000 (11:27 -0500)
committerMukunda Modell <mmodell@wikimedia.org>
Mon, 26 Jun 2017 16:29:26 +0000 (11:29 -0500)
This generates useless logspam and should be logged with a lower
log level.

Bug: T149353
Change-Id: If5e84b89eca098ac7f8c788ca3b0d268adf799fb

includes/libs/rdbms/loadbalancer/LoadBalancer.php

index 0fc00a8..0b70010 100644 (file)
@@ -1257,7 +1257,7 @@ class LoadBalancer implements ILoadBalancer {
                                // This happens if onTransactionIdle() callbacks leave callbacks on *another* DB
                                // (which finished its callbacks already). Warn and recover in this case. Let the
                                // callbacks run in the final commitMasterChanges() in LBFactory::shutdown().
-                               $this->queryLogger->error( __METHOD__ . ": found writes/callbacks pending." );
+                               $this->queryLogger->info( __METHOD__ . ": found writes/callbacks pending." );
                                return;
                        } elseif ( $conn->trxLevel() ) {
                                // This happens for single-DB setups where DB_REPLICA uses the master DB,