registration: Fix adding $formerGlobals in conversion script
authorKunal Mehta <legoktm@member.fsf.org>
Mon, 8 Aug 2016 09:56:39 +0000 (02:56 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Mon, 8 Aug 2016 09:56:39 +0000 (02:56 -0700)
Using + for two arrays does not work if they are using numerical
indexes.

Bug: T142344
Change-Id: I49541bd344fa81d20c9b4cf61b968b58137ab140

maintenance/convertExtensionToRegistration.php

index e83d7c6..0554949 100644 (file)
@@ -66,7 +66,7 @@ class ConvertExtensionToRegistration extends Maintenance {
                $processor = new ReflectionClass( 'ExtensionProcessor' );
                $settings = $processor->getProperty( 'globalSettings' );
                $settings->setAccessible( true );
-               return $settings->getValue() + $this->formerGlobals;
+               return array_merge( $settings->getValue(), $this->formerGlobals );
        }
 
        public function execute() {