BlockRestriction::update() unnecessarily does a SELECT on the page table.

This unnecessary SELECT causes a performence issue where it takes an
exceedingly long time to perform an update.

Bug: T208526
Change-Id: I0238234146fc838067019351ea97046a7d37d6fc

diff --git a/includes/block/BlockRestriction.php b/includes/block/BlockRestriction.php
index 3ce682b..43d70e6 100644 (file)
--- a/includes/block/BlockRestriction.php
+++ b/includes/block/BlockRestriction.php
@@ -112,7 +112,7 @@ class BlockRestriction {
                $blockIds = array_keys( $restrictionList );
                if ( !empty( $blockIds ) ) {
                        $result = $dbw->select(
-                               [ 'ipblocks_restrictions', 'page' ],
+                               [ 'ipblocks_restrictions' ],
                                [ 'ir_ipb_id', 'ir_type', 'ir_value' ],
                                [ 'ir_ipb_id' => $blockIds ],
                                __METHOD__,