rdbms: remove some dead code in LoadBalancer::setDomainPrefix
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 16 Aug 2018 13:31:11 +0000 (06:31 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 16 Aug 2018 13:31:11 +0000 (06:31 -0700)
Change-Id: I594a390b446c00eb604b0be63f67b2c8cbd45758

includes/libs/rdbms/loadbalancer/LoadBalancer.php

index 5e08094..fbc3be9 100644 (file)
@@ -1928,14 +1928,14 @@ class LoadBalancer implements ILoadBalancer {
                                "Foreign domain connections are still in use ($domains)." );
                }
 
-               $oldDomain = $this->localDomain->getId();
                $this->setLocalDomain( new DatabaseDomain(
                        $this->localDomain->getDatabase(),
                        $this->localDomain->getSchema(),
                        $prefix
                ) );
 
-               $this->forEachOpenConnection( function ( IDatabase $db ) use ( $prefix, $oldDomain ) {
+               // Update the prefix for all local connections...
+               $this->forEachOpenConnection( function ( IDatabase $db ) use ( $prefix ) {
                        if ( !$db->getLBInfo( 'foreign' ) ) {
                                $db->tablePrefix( $prefix );
                        }