JobQueue: Actually return the value from getRootJobCacheKey()
authorBrad Jorsch <bjorsch@wikimedia.org>
Wed, 14 Nov 2018 18:41:04 +0000 (13:41 -0500)
committerBrad Jorsch <bjorsch@wikimedia.org>
Wed, 14 Nov 2018 18:41:04 +0000 (13:41 -0500)
I8d94a650e accidentally left out the 'return' keyword, so the function
returns null.

Bug: T209429
Change-Id: Ie29c1ea5eab6ddedd0fe58010fc9cf8e3a6e2f12

includes/jobqueue/JobQueue.php

index 7d34f32..3689ba4 100644 (file)
@@ -531,7 +531,7 @@ abstract class JobQueue {
         * @return string
         */
        protected function getRootJobCacheKey( $signature ) {
-               $this->dupCache->makeGlobalKey(
+               return $this->dupCache->makeGlobalKey(
                        'jobqueue',
                        $this->domain,
                        $this->type,