Output info in update.php for skipped updates due to shared tables
authorBrian Wolff <bawolff+wn@gmail.com>
Wed, 16 Apr 2014 20:45:26 +0000 (17:45 -0300)
committerBrian Wolff <bawolff+wn@gmail.com>
Wed, 16 Apr 2014 20:45:26 +0000 (17:45 -0300)
Can be kind of confusing for people to figure out why certain
updates didn't happen. I just had an irc conversation with
someone who didn't realize why their db wasn't fully updated.

Change-Id: I56223e70bdac8baaf079c28cbb1f0e20ef0336b8

includes/installer/DatabaseUpdater.php

index 5223cd3..b7a718f 100644 (file)
@@ -531,7 +531,12 @@ abstract class DatabaseUpdater {
                        return true;
                }
 
-               return !in_array( $name, $wgSharedTables );
+               if ( in_array( $name, $wgSharedTables ) ) {
+                       $this->output( "...skipping update to shared table $name.\n" );
+                       return false;
+               } else {
+                       return true;
+               }
        }
 
        /**