tests/phpunit/includes/db/DatabaseSqliteTest.php

   1 <?php
   2
   3 use Wikimedia\Rdbms\Blob;
   4 use Wikimedia\Rdbms\Database;
   5 use Wikimedia\Rdbms\DatabaseSqlite;
   6
   7 class DatabaseSqliteMock extends DatabaseSqlite {
   8         private $lastQuery;
   9
  10         public static function newInstance( array $p = [] ) {
  11                 $p['dbFilePath'] = ':memory:';
  12                 $p['schema'] = false;
  13
  14                 return Database::factory( 'SqliteMock', $p );
  15         }
  16
  17         function query( $sql, $fname = '', $tempIgnore = false ) {
  18                 $this->lastQuery = $sql;
  19
  20                 return true;
  21         }
  22
  23         /**
  24          * Override parent visibility to public
  25          */
  26         public function replaceVars( $s ) {
  27                 return parent::replaceVars( $s );
  28         }
  29 }
  30
  31 /**
  32  * @group sqlite
  33  * @group Database
  34  * @group medium
  35  */
  36 class DatabaseSqliteTest extends MediaWikiTestCase {
  37         /** @var DatabaseSqliteMock */
  38         protected $db;
  39
  40         protected function setUp() {
  41                 parent::setUp();
  42
  43                 if ( !Sqlite::isPresent() ) {
  44                         $this->markTestSkipped( 'No SQLite support detected' );
  45                 }
  46                 $this->db = DatabaseSqliteMock::newInstance();
  47                 if ( version_compare( $this->db->getServerVersion(), '3.6.0', '<' ) ) {
  48                         $this->markTestSkipped( "SQLite at least 3.6 required, {$this->db->getServerVersion()} found" );
  49                 }
  50         }
  51
  52         private function replaceVars( $sql ) {
  53                 // normalize spacing to hide implementation details
  54                 return preg_replace( '/\s+/', ' ', $this->db->replaceVars( $sql ) );
  55         }
  56
  57         private function assertResultIs( $expected, $res ) {
  58                 $this->assertNotNull( $res );
  59                 $i = 0;
  60                 foreach ( $res as $row ) {
  61                         foreach ( $expected[$i] as $key => $value ) {
  62                                 $this->assertTrue( isset( $row->$key ) );
  63                                 $this->assertEquals( $value, $row->$key );
  64                         }
  65                         $i++;
  66                 }
  67                 $this->assertEquals( count( $expected ), $i, 'Unexpected number of rows' );
  68         }
  69
  70         public static function provideAddQuotes() {
  71                 return [
  72                         [ // #0: empty
  73                                 '', "''"
  74                         ],
  75                         [ // #1: simple
  76                                 'foo bar', "'foo bar'"
  77                         ],
  78                         [ // #2: including quote
  79                                 'foo\'bar', "'foo''bar'"
  80                         ],
  81                         // #3: including \0 (must be represented as hex, per https://bugs.php.net/bug.php?id=63419)
  82                         [
  83                                 "x\0y",
  84                                 "x'780079'",
  85                         ],
  86                         [ // #4: blob object (must be represented as hex)
  87                                 new Blob( "hello" ),
  88                                 "x'68656c6c6f'",
  89                         ],
  90                 ];
  91         }
  92
  93         /**
  94          * @dataProvider provideAddQuotes()
  95          * @covers DatabaseSqlite::addQuotes
  96          */
  97         public function testAddQuotes( $value, $expected ) {
  98                 // check quoting
  99                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 100                 $this->assertEquals( $expected, $db->addQuotes( $value ), 'string not quoted as expected' );
 101
 102                 // ok, quoting works as expected, now try a round trip.
 103                 $re = $db->query( 'select ' . $db->addQuotes( $value ) );
 104
 105                 $this->assertTrue( $re !== false, 'query failed' );
 106
 107                 $row = $re->fetchRow();
 108                 if ( $row ) {
 109                         if ( $value instanceof Blob ) {
 110                                 $value = $value->fetch();
 111                         }
 112
 113                         $this->assertEquals( $value, $row[0], 'string mangled by the database' );
 114                 } else {
 115                         $this->fail( 'query returned no result' );
 116                 }
 117         }
 118
 119         /**
 120          * @covers DatabaseSqlite::replaceVars
 121          */
 122         public function testReplaceVars() {
 123                 $this->assertEquals( 'foo', $this->replaceVars( 'foo' ), "Don't break anything accidentally" );
 124
 125                 $this->assertEquals(
 126                         "CREATE TABLE /**/foo (foo_key INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT, "
 127                                 . "foo_bar TEXT, foo_name TEXT NOT NULL DEFAULT '', foo_int INTEGER, foo_int2 INTEGER );",
 128                         $this->replaceVars(
 129                                 "CREATE TABLE /**/foo (foo_key int unsigned NOT NULL PRIMARY KEY AUTO_INCREMENT, "
 130                                 . "foo_bar char(13), foo_name varchar(255) binary NOT NULL DEFAULT '', "
 131                                 . "foo_int tinyint ( 8 ), foo_int2 int(16) ) ENGINE=MyISAM;"
 132                         )
 133                 );
 134
 135                 $this->assertEquals(
 136                         "CREATE TABLE foo ( foo1 REAL, foo2 REAL, foo3 REAL );",
 137                         $this->replaceVars(
 138                                 "CREATE TABLE foo ( foo1 FLOAT, foo2 DOUBLE( 1,10), foo3 DOUBLE PRECISION );"
 139                         )
 140                 );
 141
 142                 $this->assertEquals( "CREATE TABLE foo ( foo_binary1 BLOB, foo_binary2 BLOB );",
 143                         $this->replaceVars( "CREATE TABLE foo ( foo_binary1 binary(16), foo_binary2 varbinary(32) );" )
 144                 );
 145
 146                 $this->assertEquals( "CREATE TABLE text ( text_foo TEXT );",
 147                         $this->replaceVars( "CREATE TABLE text ( text_foo tinytext );" ),
 148                         'Table name changed'
 149                 );
 150
 151                 $this->assertEquals( "CREATE TABLE foo ( foobar INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL );",
 152                         $this->replaceVars( "CREATE TABLE foo ( foobar INT PRIMARY KEY NOT NULL AUTO_INCREMENT );" )
 153                 );
 154                 $this->assertEquals( "CREATE TABLE foo ( foobar INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL );",
 155                         $this->replaceVars( "CREATE TABLE foo ( foobar INT PRIMARY KEY AUTO_INCREMENT NOT NULL );" )
 156                 );
 157
 158                 $this->assertEquals( "CREATE TABLE enums( enum1 TEXT, myenum TEXT)",
 159                         $this->replaceVars( "CREATE TABLE enums( enum1 ENUM('A', 'B'), myenum ENUM ('X', 'Y'))" )
 160                 );
 161
 162                 $this->assertEquals( "ALTER TABLE foo ADD COLUMN foo_bar INTEGER DEFAULT 42",
 163                         $this->replaceVars( "ALTER TABLE foo\nADD COLUMN foo_bar int(10) unsigned DEFAULT 42" )
 164                 );
 165
 166                 $this->assertEquals( "DROP INDEX foo",
 167                         $this->replaceVars( "DROP INDEX /*i*/foo ON /*_*/bar" )
 168                 );
 169
 170                 $this->assertEquals( "DROP INDEX foo -- dropping index",
 171                         $this->replaceVars( "DROP INDEX /*i*/foo ON /*_*/bar -- dropping index" )
 172                 );
 173                 $this->assertEquals( "INSERT OR IGNORE INTO foo VALUES ('bar')",
 174                         $this->replaceVars( "INSERT OR IGNORE INTO foo VALUES ('bar')" )
 175                 );
 176         }
 177
 178         /**
 179          * @covers DatabaseSqlite::tableName
 180          */
 181         public function testTableName() {
 182                 // @todo Moar!
 183                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 184                 $this->assertEquals( 'foo', $db->tableName( 'foo' ) );
 185                 $this->assertEquals( 'sqlite_master', $db->tableName( 'sqlite_master' ) );
 186                 $db->tablePrefix( 'foo' );
 187                 $this->assertEquals( 'sqlite_master', $db->tableName( 'sqlite_master' ) );
 188                 $this->assertEquals( 'foobar', $db->tableName( 'bar' ) );
 189         }
 190
 191         /**
 192          * @covers DatabaseSqlite::duplicateTableStructure
 193          */
 194         public function testDuplicateTableStructure() {
 195                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 196                 $db->query( 'CREATE TABLE foo(foo, barfoo)' );
 197                 $db->query( 'CREATE INDEX index1 ON foo(foo)' );
 198                 $db->query( 'CREATE UNIQUE INDEX index2 ON foo(barfoo)' );
 199
 200                 $db->duplicateTableStructure( 'foo', 'bar' );
 201                 $this->assertEquals( 'CREATE TABLE "bar"(foo, barfoo)',
 202                         $db->selectField( 'sqlite_master', 'sql', [ 'name' => 'bar' ] ),
 203                         'Normal table duplication'
 204                 );
 205                 $indexList = $db->query( 'PRAGMA INDEX_LIST("bar")' );
 206                 $index = $indexList->next();
 207                 $this->assertEquals( 'bar_index1', $index->name );
 208                 $this->assertEquals( '0', $index->unique );
 209                 $index = $indexList->next();
 210                 $this->assertEquals( 'bar_index2', $index->name );
 211                 $this->assertEquals( '1', $index->unique );
 212
 213                 $db->duplicateTableStructure( 'foo', 'baz', true );
 214                 $this->assertEquals( 'CREATE TABLE "baz"(foo, barfoo)',
 215                         $db->selectField( 'sqlite_temp_master', 'sql', [ 'name' => 'baz' ] ),
 216                         'Creation of temporary duplicate'
 217                 );
 218                 $indexList = $db->query( 'PRAGMA INDEX_LIST("baz")' );
 219                 $index = $indexList->next();
 220                 $this->assertEquals( 'baz_index1', $index->name );
 221                 $this->assertEquals( '0', $index->unique );
 222                 $index = $indexList->next();
 223                 $this->assertEquals( 'baz_index2', $index->name );
 224                 $this->assertEquals( '1', $index->unique );
 225                 $this->assertEquals( 0,
 226                         $db->selectField( 'sqlite_master', 'COUNT(*)', [ 'name' => 'baz' ] ),
 227                         'Create a temporary duplicate only'
 228                 );
 229         }
 230
 231         /**
 232          * @covers DatabaseSqlite::duplicateTableStructure
 233          */
 234         public function testDuplicateTableStructureVirtual() {
 235                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 236                 if ( $db->getFulltextSearchModule() != 'FTS3' ) {
 237                         $this->markTestSkipped( 'FTS3 not supported, cannot create virtual tables' );
 238                 }
 239                 $db->query( 'CREATE VIRTUAL TABLE "foo" USING FTS3(foobar)' );
 240
 241                 $db->duplicateTableStructure( 'foo', 'bar' );
 242                 $this->assertEquals( 'CREATE VIRTUAL TABLE "bar" USING FTS3(foobar)',
 243                         $db->selectField( 'sqlite_master', 'sql', [ 'name' => 'bar' ] ),
 244                         'Duplication of virtual tables'
 245                 );
 246
 247                 $db->duplicateTableStructure( 'foo', 'baz', true );
 248                 $this->assertEquals( 'CREATE VIRTUAL TABLE "baz" USING FTS3(foobar)',
 249                         $db->selectField( 'sqlite_master', 'sql', [ 'name' => 'baz' ] ),
 250                         "Can't create temporary virtual tables, should fall back to non-temporary duplication"
 251                 );
 252         }
 253
 254         /**
 255          * @covers DatabaseSqlite::deleteJoin
 256          */
 257         public function testDeleteJoin() {
 258                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 259                 $db->query( 'CREATE TABLE a (a_1)', __METHOD__ );
 260                 $db->query( 'CREATE TABLE b (b_1, b_2)', __METHOD__ );
 261                 $db->insert( 'a', [
 262                                 [ 'a_1' => 1 ],
 263                                 [ 'a_1' => 2 ],
 264                                 [ 'a_1' => 3 ],
 265                         ],
 266                         __METHOD__
 267                 );
 268                 $db->insert( 'b', [
 269                                 [ 'b_1' => 2, 'b_2' => 'a' ],
 270                                 [ 'b_1' => 3, 'b_2' => 'b' ],
 271                         ],
 272                         __METHOD__
 273                 );
 274                 $db->deleteJoin( 'a', 'b', 'a_1', 'b_1', [ 'b_2' => 'a' ], __METHOD__ );
 275                 $res = $db->query( "SELECT * FROM a", __METHOD__ );
 276                 $this->assertResultIs( [
 277                                 [ 'a_1' => 1 ],
 278                                 [ 'a_1' => 3 ],
 279                         ],
 280                         $res
 281                 );
 282         }
 283
 284         public function testEntireSchema() {
 285                 global $IP;
 286
 287                 $result = Sqlite::checkSqlSyntax( "$IP/maintenance/tables.sql" );
 288                 if ( $result !== true ) {
 289                         $this->fail( $result );
 290                 }
 291                 $this->assertTrue( true ); // avoid test being marked as incomplete due to lack of assertions
 292         }
 293
 294         /**
 295          * Runs upgrades of older databases and compares results with current schema
 296          * @todo Currently only checks list of tables
 297          */
 298         public function testUpgrades() {
 299                 global $IP, $wgVersion, $wgProfiler;
 300
 301                 // Versions tested
 302                 $versions = [
 303                         // '1.13', disabled for now, was totally screwed up
 304                         // SQLite wasn't included in 1.14
 305                         '1.15',
 306                         '1.16',
 307                         '1.17',
 308                         '1.18',
 309                 ];
 310
 311                 // Mismatches for these columns we can safely ignore
 312                 $ignoredColumns = [
 313                         'user_newtalk.user_last_timestamp', // r84185
 314                 ];
 315
 316                 $currentDB = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 317                 $currentDB->sourceFile( "$IP/maintenance/tables.sql" );
 318
 319                 $profileToDb = false;
 320                 if ( isset( $wgProfiler['output'] ) ) {
 321                         $out = $wgProfiler['output'];
 322                         if ( $out === 'db' ) {
 323                                 $profileToDb = true;
 324                         } elseif ( is_array( $out ) && in_array( 'db', $out ) ) {
 325                                 $profileToDb = true;
 326                         }
 327                 }
 328
 329                 if ( $profileToDb ) {
 330                         $currentDB->sourceFile( "$IP/maintenance/sqlite/archives/patch-profiling.sql" );
 331                 }
 332                 $currentTables = $this->getTables( $currentDB );
 333                 sort( $currentTables );
 334
 335                 foreach ( $versions as $version ) {
 336                         $versions = "upgrading from $version to $wgVersion";
 337                         $db = $this->prepareTestDB( $version );
 338                         $tables = $this->getTables( $db );
 339                         $this->assertEquals( $currentTables, $tables, "Different tables $versions" );
 340                         foreach ( $tables as $table ) {
 341                                 $currentCols = $this->getColumns( $currentDB, $table );
 342                                 $cols = $this->getColumns( $db, $table );
 343                                 $this->assertEquals(
 344                                         array_keys( $currentCols ),
 345                                         array_keys( $cols ),
 346                                         "Mismatching columns for table \"$table\" $versions"
 347                                 );
 348                                 foreach ( $currentCols as $name => $column ) {
 349                                         $fullName = "$table.$name";
 350                                         $this->assertEquals(
 351                                                 (bool)$column->pk,
 352                                                 (bool)$cols[$name]->pk,
 353                                                 "PRIMARY KEY status does not match for column $fullName $versions"
 354                                         );
 355                                         if ( !in_array( $fullName, $ignoredColumns ) ) {
 356                                                 $this->assertEquals(
 357                                                         (bool)$column->notnull,
 358                                                         (bool)$cols[$name]->notnull,
 359                                                         "NOT NULL status does not match for column $fullName $versions"
 360                                                 );
 361                                                 $this->assertEquals(
 362                                                         $column->dflt_value,
 363                                                         $cols[$name]->dflt_value,
 364                                                         "Default values does not match for column $fullName $versions"
 365                                                 );
 366                                         }
 367                                 }
 368                                 $currentIndexes = $this->getIndexes( $currentDB, $table );
 369                                 $indexes = $this->getIndexes( $db, $table );
 370                                 $this->assertEquals(
 371                                         array_keys( $currentIndexes ),
 372                                         array_keys( $indexes ),
 373                                         "mismatching indexes for table \"$table\" $versions"
 374                                 );
 375                         }
 376                         $db->close();
 377                 }
 378         }
 379
 380         /**
 381          * @covers DatabaseSqlite::insertId
 382          */
 383         public function testInsertIdType() {
 384                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 385
 386                 $databaseCreation = $db->query( 'CREATE TABLE a ( a_1 )', __METHOD__ );
 387                 $this->assertInstanceOf( 'ResultWrapper', $databaseCreation, "Database creation" );
 388
 389                 $insertion = $db->insert( 'a', [ 'a_1' => 10 ], __METHOD__ );
 390                 $this->assertTrue( $insertion, "Insertion worked" );
 391
 392                 $this->assertInternalType( 'integer', $db->insertId(), "Actual typecheck" );
 393                 $this->assertTrue( $db->close(), "closing database" );
 394         }
 395
 396         private function prepareTestDB( $version ) {
 397                 static $maint = null;
 398                 if ( $maint === null ) {
 399                         $maint = new FakeMaintenance();
 400                         $maint->loadParamsAndArgs( null, [ 'quiet' => 1 ] );
 401                 }
 402
 403                 global $IP;
 404                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 405                 $db->sourceFile( "$IP/tests/phpunit/data/db/sqlite/tables-$version.sql" );
 406                 $updater = DatabaseUpdater::newForDB( $db, false, $maint );
 407                 $updater->doUpdates( [ 'core' ] );
 408
 409                 return $db;
 410         }
 411
 412         private function getTables( $db ) {
 413                 $list = array_flip( $db->listTables() );
 414                 $excluded = [
 415                         'external_user', // removed from core in 1.22
 416                         'math', // moved out of core in 1.18
 417                         'trackbacks', // removed from core in 1.19
 418                         'searchindex',
 419                         'searchindex_content',
 420                         'searchindex_segments',
 421                         'searchindex_segdir',
 422                         // FTS4 ready!!1
 423                         'searchindex_docsize',
 424                         'searchindex_stat',
 425                 ];
 426                 foreach ( $excluded as $t ) {
 427                         unset( $list[$t] );
 428                 }
 429                 $list = array_flip( $list );
 430                 sort( $list );
 431
 432                 return $list;
 433         }
 434
 435         private function getColumns( $db, $table ) {
 436                 $cols = [];
 437                 $res = $db->query( "PRAGMA table_info($table)" );
 438                 $this->assertNotNull( $res );
 439                 foreach ( $res as $col ) {
 440                         $cols[$col->name] = $col;
 441                 }
 442                 ksort( $cols );
 443
 444                 return $cols;
 445         }
 446
 447         private function getIndexes( $db, $table ) {
 448                 $indexes = [];
 449                 $res = $db->query( "PRAGMA index_list($table)" );
 450                 $this->assertNotNull( $res );
 451                 foreach ( $res as $index ) {
 452                         $res2 = $db->query( "PRAGMA index_info({$index->name})" );
 453                         $this->assertNotNull( $res2 );
 454                         $index->columns = [];
 455                         foreach ( $res2 as $col ) {
 456                                 $index->columns[] = $col;
 457                         }
 458                         $indexes[$index->name] = $index;
 459                 }
 460                 ksort( $indexes );
 461
 462                 return $indexes;
 463         }
 464
 465         public function testCaseInsensitiveLike() {
 466                 // TODO: Test this for all databases
 467                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 468                 $res = $db->query( 'SELECT "a" LIKE "A" AS a' );
 469                 $row = $res->fetchRow();
 470                 $this->assertFalse( (bool)$row['a'] );
 471         }
 472
 473         /**
 474          * @covers DatabaseSqlite::numFields
 475          */
 476         public function testNumFields() {
 477                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 478
 479                 $databaseCreation = $db->query( 'CREATE TABLE a ( a_1 )', __METHOD__ );
 480                 $this->assertInstanceOf( 'ResultWrapper', $databaseCreation, "Failed to create table a" );
 481                 $res = $db->select( 'a', '*' );
 482                 $this->assertEquals( 0, $db->numFields( $res ), "expects to get 0 fields for an empty table" );
 483                 $insertion = $db->insert( 'a', [ 'a_1' => 10 ], __METHOD__ );
 484                 $this->assertTrue( $insertion, "Insertion failed" );
 485                 $res = $db->select( 'a', '*' );
 486                 $this->assertEquals( 1, $db->numFields( $res ), "wrong number of fields" );
 487
 488                 $this->assertTrue( $db->close(), "closing database" );
 489         }
 490
 491         public function testToString() {
 492                 $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
 493
 494                 $toString = (string)$db;
 495
 496                 $this->assertContains( 'SQLite ', $toString );
 497         }
 498 }