lhc/web/wiklou.git
10 years agoMove release notes for "Move redirect rendering into WikitextContent" to 1.24
Timo Tijhof [Wed, 21 May 2014 15:41:19 +0000 (17:41 +0200)]
Move release notes for "Move redirect rendering into WikitextContent" to 1.24

Follows-up Id44d566a7ca3, the commit was merged before the
branch cut and then reverted in REL_23 (I7431eb83a092).
The notes were never fixed in master.

Change-Id: I9ef5263ac8f7b8050bb1c6e7933cde6020389c90

10 years agoSync 1.23 release notes for bug 13250 from REL1_23
Timo Tijhof [Wed, 21 May 2014 15:30:54 +0000 (17:30 +0200)]
Sync 1.23 release notes for bug 13250 from REL1_23

Change I17dde71858fa655 was merged after the branch cut, and did
not have release notes. Then whoever backported it to REL1_23 decided
it really should have release notes and wrote them directly in
REL1_23...

Change-Id: Iceeb6c039059e11c1854e32ee086ec9f53f29a03

10 years agoSync 1.23 release notes for bug 64289 from REL1_23
Timo Tijhof [Wed, 21 May 2014 15:27:54 +0000 (17:27 +0200)]
Sync 1.23 release notes for bug 64289 from REL1_23

Change Ib97f47ef1 was merged after the branch cut, but did not
have release notes. Then whoever backported it to REL1_23 decided
it really should have release notes and wrote them directly in
REL1_23...

Change-Id: I5d36dc86f10e757cac286bcb9b63c9e711a921b9

10 years agoMove release notes for "Introducing pp_sortkey" to 1.24
Timo Tijhof [Wed, 21 May 2014 15:22:57 +0000 (17:22 +0200)]
Move release notes for "Introducing pp_sortkey" to 1.24

Follows-up I217c42656 and Iaa78a8254, the commit was merged
before the branch cut and then reverted in REL1_23. The notes
were never fixed in master.

Change-Id: I5355ac405aef4d2b0d660205bc1231c6eb35c02d

10 years agoFixup typography changes release notes between 1.23 and 1.14
Timo Tijhof [Wed, 21 May 2014 15:04:28 +0000 (17:04 +0200)]
Fixup typography changes release notes between 1.23 and 1.14

Hotfix I595feec9a to REL1_23 changes release notes directly
in REL1_23 without applying to master first. The files are now
out of sync.

* Sync the line in RELEASE-NOTES-1.23 with what is in REL1_23
  (basically cherry-picking hotfix I595feec9a from REL1_23 to
  master here).

* Move the remainder to RELEASE-NOTES-1.24.

Change-Id: Ic3dc2655101086521403cfc9929887a97bbed811

10 years agoMove release notes for "Introducing pp_sortkey" to 1.24
Timo Tijhof [Wed, 21 May 2014 14:54:54 +0000 (16:54 +0200)]
Move release notes for "Introducing pp_sortkey" to 1.24

Follows-up I217c42656fb877f, the commit was merged after the
branch cut and was not backported.

Change-Id: Iaa78a8254b3114600052005ce28d752b5f472354

10 years agoAdd method to determine EnhancedChangesList cache grouping key
aude [Fri, 11 Apr 2014 10:35:42 +0000 (12:35 +0200)]
Add method to determine EnhancedChangesList cache grouping key

Change-Id: Iaf3734baa53b71affca77d5243a579cc70bb522b

10 years agoMerge "mediawiki.searchSuggest: Code clean up"
jenkins-bot [Wed, 21 May 2014 13:21:20 +0000 (13:21 +0000)]
Merge "mediawiki.searchSuggest: Code clean up"

10 years agoMerge "mediawiki.toc.test: Stub $.cookie to avoid test pollution"
jenkins-bot [Wed, 21 May 2014 13:03:09 +0000 (13:03 +0000)]
Merge "mediawiki.toc.test: Stub $.cookie to avoid test pollution"

10 years agoMerge "Inserted test whether the resource 'uploadsource' is already registered. Bug...
jenkins-bot [Wed, 21 May 2014 09:31:41 +0000 (09:31 +0000)]
Merge "Inserted test whether the resource 'uploadsource' is already registered. Bug: 65530"

10 years agomediawiki.searchSuggest: Code clean up
Timo Tijhof [Wed, 21 May 2014 01:07:08 +0000 (03:07 +0200)]
mediawiki.searchSuggest: Code clean up

* Cache mw.Api instance.
* Remove redundant "str.length" check in fetch(),
  jquery.suggestions already takes care of this (it never calls
  fetch if the string is empty, and if it did, then this code would've
  left it unhandled causing bugs (e.g. suggestions of the previous
  fetch remain visible).
* Remove redundant promise.abort check.
* Use $.data() and $.removeData() to bypass unneeded convenience
  logic for collections and HTML data attributes.

Change-Id: I59ae21c4b481ef52e4db14cb1f3f2fe026c23b3f

10 years agoMerge "Tweaked timestamp kludge logic in recordUpload2"
jenkins-bot [Tue, 20 May 2014 23:34:29 +0000 (23:34 +0000)]
Merge "Tweaked timestamp kludge logic in recordUpload2"

10 years agoMerge "Replace FOR UPDATE with LockManager use in LocalFile::lock()"
jenkins-bot [Tue, 20 May 2014 22:07:21 +0000 (22:07 +0000)]
Merge "Replace FOR UPDATE with LockManager use in LocalFile::lock()"

10 years agoTweaked timestamp kludge logic in recordUpload2
Aaron Schulz [Tue, 20 May 2014 21:40:42 +0000 (14:40 -0700)]
Tweaked timestamp kludge logic in recordUpload2

* This now only does the SELECT FOR UPDATE for the re-upload case

Change-Id: I21b1b0328b6dbfb30f4f0293212515b9ee081778

10 years agoReplace FOR UPDATE with LockManager use in LocalFile::lock()
Aaron Schulz [Tue, 20 May 2014 21:22:52 +0000 (14:22 -0700)]
Replace FOR UPDATE with LockManager use in LocalFile::lock()

* This avoids excess contention where inserts of rows for
  similarly named files get blocked. This often would effect
  users of UploadWizard or any bot doing mass uploads.

Change-Id: Ie7a328f7d4f03aa249770804417347a50356ea42

10 years agoMerge "Update kss style guide wording and README"
jenkins-bot [Tue, 20 May 2014 21:14:33 +0000 (21:14 +0000)]
Merge "Update kss style guide wording and README"

10 years agoMerge "Improve rendering of Living Style Guide sections, examples, and modifiers."
jenkins-bot [Tue, 20 May 2014 21:08:18 +0000 (21:08 +0000)]
Merge "Improve rendering of Living Style Guide sections, examples, and modifiers."

10 years agoExpand doc of ApiBase::require*Parameter functions
umherirrender [Tue, 13 May 2014 18:37:41 +0000 (20:37 +0200)]
Expand doc of ApiBase::require*Parameter functions

Add a hint to the getError function which should be called in the
getPossibleErrors() function.
Also do this for getTitleOrPageId.

Change-Id: I601feb8a5b8699ce4d81814aa3cd127552a525ac

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 20 May 2014 18:42:01 +0000 (18:42 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I7ddc1117c5f50186185cc66ebcc019ff1d4781a6

10 years agoMerge "Collation: Remove deprecated findLowerBound()"
jenkins-bot [Tue, 20 May 2014 17:52:28 +0000 (17:52 +0000)]
Merge "Collation: Remove deprecated findLowerBound()"

10 years agoMerge "User::pingLimiter() profiles per action as well"
jenkins-bot [Tue, 20 May 2014 17:41:19 +0000 (17:41 +0000)]
Merge "User::pingLimiter() profiles per action as well"

10 years agoMerge "Pass archived page id to ArticleUndelete hook."
Phuedx [Tue, 20 May 2014 17:06:14 +0000 (17:06 +0000)]
Merge "Pass archived page id to ArticleUndelete hook."

10 years agoPass archived page id to ArticleUndelete hook.
Rob Moen [Thu, 15 May 2014 22:51:52 +0000 (15:51 -0700)]
Pass archived page id to ArticleUndelete hook.

Needed for instrumentation of PageRestoration schema

Rationale:  By the time the hook runs, there is no longer record
of the previous page id.

Change-Id: If87a73e47def7a4404858f374780c3f1cf4d69b5
See: https://meta.wikimedia.org/wiki/Schema:PageRestoration
Needed by: Id40347ec268658dc854e4ab2dd38570b19db1477

10 years agomediawiki.toc.test: Stub $.cookie to avoid test pollution
Timo Tijhof [Tue, 20 May 2014 14:40:55 +0000 (16:40 +0200)]
mediawiki.toc.test: Stub $.cookie to avoid test pollution

When running the tests locally the mediawiki.toc tests often
fail because where it asserts hidden it is visible, and where it
asserts visible it is hidden (this happens if you've ever closed
a "toc" section on your local wiki, causes the tests to be one-off).

Change-Id: Idc5e7123f3be3e11dac50d76d13089a2fabcfdb5

10 years agoInserted test whether the resource 'uploadsource' is already registered.
Alexander Lehmann [Tue, 20 May 2014 12:26:33 +0000 (14:26 +0200)]
Inserted test whether the resource 'uploadsource' is already registered.
Bug: 65530

Change-Id: I1b82d6dc6a37792d4e7b7d01316802ea4d38a88b

10 years agoMerge "API: Fix prop=revisions&rvdiffto= without rvprop=content"
jenkins-bot [Tue, 20 May 2014 01:34:12 +0000 (01:34 +0000)]
Merge "API: Fix prop=revisions&rvdiffto= without rvprop=content"

10 years agoAdd RELEASE-NOTES entry for 87e0aa344176d9877bffdf77e222439ec0a99f9e
C. Scott Ananian [Mon, 19 May 2014 22:54:48 +0000 (15:54 -0700)]
Add RELEASE-NOTES entry for 87e0aa344176d9877bffdf77e222439ec0a99f9e

Change-Id: Idbd61178c76ec2104791031fe2c6ee84a3daf632

10 years agoIndicate whether interwiki links can use protocol-relative URLs.
C. Scott Ananian [Mon, 19 May 2014 22:22:32 +0000 (15:22 -0700)]
Indicate whether interwiki links can use protocol-relative URLs.

Change-Id: I17360e44f0be7490357bc9bc7af27d0a950012de

10 years agoUpdate OOjs UI to v0.1.0-pre (0fbf6bd14e)
Roan Kattouw [Mon, 19 May 2014 21:09:32 +0000 (14:09 -0700)]
Update OOjs UI to v0.1.0-pre (0fbf6bd14e)

New changes:
ab5ebc6 Localisation updates from https://translatewiki.net.
39a1496 Make flags on buttons in confirmation dialog configurable

Change-Id: I6c67b919003a33b1617ad36734bde489d79d916c

10 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Mon, 19 May 2014 19:49:32 +0000 (19:49 +0000)]
Merge "Localisation updates from https://translatewiki.net."

10 years agoMerge "Make phpcs-strict pass on includes/ (7/7)"
jenkins-bot [Mon, 19 May 2014 19:38:53 +0000 (19:38 +0000)]
Merge "Make phpcs-strict pass on includes/ (7/7)"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 19 May 2014 19:35:06 +0000 (19:35 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Icc1e3c9406a1b0e2af89d2e8d2d0ca2119da0607

10 years agoMerge "mediawiki.htmlform: Refactor and clean up"
jenkins-bot [Mon, 19 May 2014 19:34:16 +0000 (19:34 +0000)]
Merge "mediawiki.htmlform: Refactor and clean up"

10 years agoMerge "Move ApiQueryRecentChanges::parseRCType to static method on RecentChange"
jenkins-bot [Mon, 19 May 2014 18:57:25 +0000 (18:57 +0000)]
Merge "Move ApiQueryRecentChanges::parseRCType to static method on RecentChange"

10 years agoMerge "IP class cleanups"
jenkins-bot [Mon, 19 May 2014 18:29:09 +0000 (18:29 +0000)]
Merge "IP class cleanups"

10 years agoUpdate OOjs UI to v0.1.0-pre (521a9e242b)
Roan Kattouw [Mon, 19 May 2014 17:42:48 +0000 (10:42 -0700)]
Update OOjs UI to v0.1.0-pre (521a9e242b)

New changes:
1429076 Upgrade jQuery from 1.8.2 to 1.11.1
f14c3b2 Localisation updates from https://translatewiki.net.
8612e00 Localisation updates from https://translatewiki.net.
521a9e2 Window: Apply display:none after initialize, not before

Change-Id: Ieabe267b13dee1c2c419ccf12e910e349a7e3768

10 years agomediawiki.htmlform: Refactor and clean up
Timo Tijhof [Fri, 9 May 2014 08:44:34 +0000 (10:44 +0200)]
mediawiki.htmlform: Refactor and clean up

* Use .filter function instead of concatenating strings.
  The end result is the same.

  It's faster and more stable and semantically correct this way
  because using the string syntax is subject to bugs when using
  special characters (you'd have to escape it first, which is
  non-trivial to do in CSS selectors, sometimes impossible).
  So comparing the .name property against a string value directly
  is much easier.

* Use .prop() instead of .attr() where appropiate.
  attr() changes attribute nodes only in the DOM, properties
  reflect the actual live rendered value. This works because of
  a back-compat layer in jQuery, but has been deprecated.

* Use a simple array and create 1 jQuery object, instead of
  creating various temporary objects only to have jQuery merge
  them via .add(). .add() is relatively expensive in that it
  keeps a reference in pushStack and does a lot of logic. Fine
  for convenience, but since we have all the data right here,
  might as well take a more direct approach.

* Remove ill-informed $() calls. This is already a jQuery object
  for the method is a jQuery method. Cloning the object first
  leads to unexpected side-effects and is simply not neccecary.

* Remove use of .live()

Change-Id: Icfe63a4111026661c53639b72e67a4d4fa3d6ac2

10 years agoMerge "Fixed job miscounting bug when a string digit is returned"
jenkins-bot [Mon, 19 May 2014 17:27:47 +0000 (17:27 +0000)]
Merge "Fixed job miscounting bug when a string digit is returned"

10 years agoFixed job miscounting bug when a string digit is returned
Aaron Schulz [Mon, 19 May 2014 17:12:14 +0000 (10:12 -0700)]
Fixed job miscounting bug when a string digit is returned

Change-Id: I857b56a6e78f715157c7f648929d6bf38eb74828

10 years agoCollation: Remove deprecated findLowerBound()
Bartosz Dziewoński [Mon, 19 May 2014 16:21:08 +0000 (18:21 +0200)]
Collation: Remove deprecated findLowerBound()

It was just a wrapper for ArrayUtils::findLowerBound(), it's not used
in core and it shouldn't be used anywhere outside of core (but I
haven't checked).

Change-Id: I53b0aca6bb642bdf6c972098170579fa13746554

10 years agoMerge "mediawiki.page.watch.ajax: Disable watch link while waiting for API response"
jenkins-bot [Mon, 19 May 2014 15:20:26 +0000 (15:20 +0000)]
Merge "mediawiki.page.watch.ajax: Disable watch link while waiting for API response"

10 years agomediawiki.page.watch.ajax: Disable watch link while waiting for API response
Bartosz Dziewoński [Sat, 17 May 2014 13:55:08 +0000 (15:55 +0200)]
mediawiki.page.watch.ajax: Disable watch link while waiting for API response

Previously clicking the watch link several times in a row would fire
several requests to the API, and the final result would depend on the
order in which they arrived. Let's not allow that.

This also removes the special-case for the 'loading' class, it is now
always added or removed.

Change-Id: Ib91ec8505d04945dc77e48ab70b5c94e3da47d9c

10 years agoMerge "mediawiki.api: Use then() in getToken instead of manual Deferred wrapping"
jenkins-bot [Mon, 19 May 2014 11:32:20 +0000 (11:32 +0000)]
Merge "mediawiki.api: Use then() in getToken instead of manual Deferred wrapping"

10 years agoMerge "mediawiki.api: Do not cache errors in getToken()"
jenkins-bot [Mon, 19 May 2014 11:31:57 +0000 (11:31 +0000)]
Merge "mediawiki.api: Do not cache errors in getToken()"

10 years agoMerge "mediawiki.user: Use mw.log.deprecate to track user() and anonymous()"
jenkins-bot [Mon, 19 May 2014 11:03:03 +0000 (11:03 +0000)]
Merge "mediawiki.user: Use mw.log.deprecate to track user() and anonymous()"

10 years agoUser::pingLimiter() profiles per action as well
Antoine Musso [Mon, 19 May 2014 10:45:11 +0000 (12:45 +0200)]
User::pingLimiter() profiles per action as well

We had an outage beginning of may that involved rate limiting of the
'renderfile-nonstandard' action.  This makes User::pingLimiter() to
record a per action profiling point in addition to the generic one, that
would let us finely graph actions being throttled.

Ref:
https://wikitech.wikimedia.org/wiki/Incident_documentation/20140503-Thumbnails#What_can_be_improved

Bug: 65477
Change-Id: Iac7930e85f7d9101663656ccb2bccdbebf908693

10 years agoMerge "jquery.tipsy: Add viewable region bounds checking"
jenkins-bot [Mon, 19 May 2014 10:13:42 +0000 (10:13 +0000)]
Merge "jquery.tipsy: Add viewable region bounds checking"

10 years agoMerge "jquery.tipsy: Merge some upstream changes"
jenkins-bot [Mon, 19 May 2014 10:12:37 +0000 (10:12 +0000)]
Merge "jquery.tipsy: Merge some upstream changes"

10 years agoopportunity to reuse Title::getEditURL()
Adam Roses Wight [Sun, 18 May 2014 20:54:46 +0000 (13:54 -0700)]
opportunity to reuse Title::getEditURL()

This will be helpful if we want to make changes to the edit URL in the future.

Change-Id: I6e877d23b041a2bd1672ae804e06bf6a52e16c9f

10 years agoMerge "Avoid fatals in begin/commit/rollback if close() was called"
jenkins-bot [Mon, 19 May 2014 04:20:00 +0000 (04:20 +0000)]
Merge "Avoid fatals in begin/commit/rollback if close() was called"

10 years agoFix error message when swap is disabled
Tim Starling [Mon, 19 May 2014 00:41:52 +0000 (10:41 +1000)]
Fix error message when swap is disabled

Bug: 65465
Change-Id: Ibb1b14f5271d60c039398e8ce8a9c2a5d245241f

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 18 May 2014 19:56:04 +0000 (19:56 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Idc2498ae827432f400c278e873295ec42aa9ca0e

10 years agojquery.tipsy: Add viewable region bounds checking
Shane Gibbons [Sun, 21 Nov 2010 20:39:42 +0000 (15:39 -0500)]
jquery.tipsy: Add viewable region bounds checking

Merge of upstream: 5a8253f

https://github.com/jaz303/tipsy/commit/5a8253f

Bug: 44382
Change-Id: I984a99a18efbb9722e820e5e5828bc6289a9a673

10 years agojquery.tipsy: Merge some upstream changes
Derk-Jan Hartman [Sun, 18 May 2014 14:01:00 +0000 (16:01 +0200)]
jquery.tipsy: Merge some upstream changes

https://github.com/jaz303/tipsy/tree/2d916c6

4b3e29f: Remove superfluous slash
23994f5: tipsy object proxy method tolerates null object
2d916c6: Always ensure native tooltip is restored

Change-Id: Id87ba461265730a56a3212c003b8321bd53a6096

10 years agoMerge "Remove unneeded $classes from SpecialTrackingCategories.php"
jenkins-bot [Sun, 18 May 2014 14:07:57 +0000 (14:07 +0000)]
Merge "Remove unneeded $classes from SpecialTrackingCategories.php"

10 years agoMerge "Update jscs and jshint config"
jenkins-bot [Sun, 18 May 2014 10:11:53 +0000 (10:11 +0000)]
Merge "Update jscs and jshint config"

10 years agoMerge "vector: Suppress watch star focus outline when animating it"
jenkins-bot [Sun, 18 May 2014 10:03:06 +0000 (10:03 +0000)]
Merge "vector: Suppress watch star focus outline when animating it"

10 years agoRemove unneeded $classes from SpecialTrackingCategories.php
umherirrender [Fri, 16 May 2014 15:50:00 +0000 (17:50 +0200)]
Remove unneeded $classes from SpecialTrackingCategories.php

Change-Id: I9f10db9f6596ac0bfe0aa1595acbeeef4ca5713a

10 years agoMerge "For job param arrays of scalars, show the key/values as JSON in the log"
jenkins-bot [Sun, 18 May 2014 02:33:30 +0000 (02:33 +0000)]
Merge "For job param arrays of scalars, show the key/values as JSON in the log"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 17 May 2014 19:47:00 +0000 (19:47 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Id6f998e098596b26744d4948c0ee37883e4d325d

10 years agoMove ApiQueryRecentChanges::parseRCType to static method on RecentChange
kishanio [Thu, 15 May 2014 10:18:28 +0000 (10:18 +0000)]
Move ApiQueryRecentChanges::parseRCType to static method on RecentChange

Prior parseRCType was an private method in includes/api/ApiQueryRecentChanges and also
duplicated in includes/api/ApiQueryWatchList. This method has been made static and moved
to includes/changes/RecentChange.php.

Bug: 65071
Change-Id: Ic911fbcf9411c782685c4f956f8522051f2517f0

10 years agovector: Suppress watch star focus outline when animating it
Bartosz Dziewoński [Sat, 17 May 2014 13:46:23 +0000 (15:46 +0200)]
vector: Suppress watch star focus outline when animating it

It looks really funny, but that's not the effect we're aiming for.
The star is not supposed to look clickable during the rotation
animation anyway.

Bug: 65434
Change-Id: I3a7c91f5b7df0d70abd532cc234e8aa1bac9e129

10 years agomediawiki.user: Use mw.log.deprecate to track user() and anonymous()
Timo Tijhof [Sat, 17 May 2014 00:54:13 +0000 (02:54 +0200)]
mediawiki.user: Use mw.log.deprecate to track user() and anonymous()

Follows-up I5970be9e859358 which deprecated these orignally.

Also remove obsolete tests now that they're linked by reference.

Change-Id: I559efa8a61de9f7b600c7b74edd5a56fb0a33b00

10 years agoUpdate OOjs UI to v0.1.0-pre (d4086ff6e6)
Roan Kattouw [Fri, 16 May 2014 23:32:43 +0000 (16:32 -0700)]
Update OOjs UI to v0.1.0-pre (d4086ff6e6)

New changes:
a635ace build: Update jscs config
fd23e56 Localisation updates from https://translatewiki.net.
f5e6413 PanelLayout: Remove call to getDir()

Change-Id: I19fe3aa6c9909ab2d970b87a5ec21a019d8bb241

10 years agoAlways render copyright notice in user language
kaldari [Mon, 24 Mar 2014 22:57:59 +0000 (15:57 -0700)]
Always render copyright notice in user language

All other footer content is rendered in the user language and the
copyright notice on the edit page is also in the user language.
See EditPage::getCopyrightWarning().

We already do this on WMF wikis through the WikimediaMessages
extension (which sets $forContent to false). The same behaviour has
been requested for 3rd party wikis as well.

Bug: 49116
Change-Id: I1dddfa7771c7063ec319fa441c2e400a374abc92

10 years agoMerge "Minor fix to DatabaseBase::close() logic"
jenkins-bot [Fri, 16 May 2014 22:40:30 +0000 (22:40 +0000)]
Merge "Minor fix to DatabaseBase::close() logic"

10 years agoFor job param arrays of scalars, show the key/values as JSON in the log
Aaron Schulz [Fri, 16 May 2014 22:23:26 +0000 (15:23 -0700)]
For job param arrays of scalars, show the key/values as JSON in the log

Change-Id: Ia9056dd1d4669102178046961ddaf6e8560e5903

10 years agoMerge "Drop rc_cur_time from recentchanges"
jenkins-bot [Fri, 16 May 2014 20:23:12 +0000 (20:23 +0000)]
Merge "Drop rc_cur_time from recentchanges"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 16 May 2014 19:55:30 +0000 (19:55 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I195193fb9a06a3f8fe09697977e075e86b11c516

10 years agoMinor fix to DatabaseBase::close() logic
Aaron Schulz [Fri, 16 May 2014 18:22:31 +0000 (11:22 -0700)]
Minor fix to DatabaseBase::close() logic

* Only set mOpened to false if closeConnection() was called (or mConn was unset)

bug: 65100
Change-Id: I1ba6b765cfc647a47f21048d993047c0fe0cfe19

10 years agoFix @since of Parser::stripOuterParagraph
umherirrender [Fri, 16 May 2014 17:50:09 +0000 (19:50 +0200)]
Fix @since of Parser::stripOuterParagraph

Was merged after release branch.

Follow-Up: I6bb3597898324556df912a23a7ffc9ff250b8f58
Change-Id: Idab16dc1e322ede31f6688236fddae5365ac133c

10 years agoAvoid fatals in begin/commit/rollback if close() was called
Aaron Schulz [Fri, 16 May 2014 17:50:05 +0000 (10:50 -0700)]
Avoid fatals in begin/commit/rollback if close() was called

Change-Id: I3c555ece5c1e16c6ffcdbec6645d659531400a1b

10 years agojquery.suggestions: Use body width instead of full document width
Fomafix [Tue, 29 Apr 2014 19:02:30 +0000 (19:02 +0000)]
jquery.suggestions: Use body width instead of full document width

When there is a overflowing element in the content, the width of
the "document" is wider than the visible width within the browser
window. Use <body> instead of document.

This reverts 4d799b48 (a fix for bug 45668).

Bug: 54091
Bug: 64233
Change-Id: I5268eaf7307159b2eaa4c5749346aa562574a6e2

10 years agoIP class cleanups
Aaron Schulz [Fri, 16 May 2014 16:04:34 +0000 (09:04 -0700)]
IP class cleanups

* Removed clumsy and unused toOctet() method
* Avoid internal use of ugly toUnsigned() method
* Use proper return value for toHex() on failure
* Converted isPublic() to use IPSet

Change-Id: I36d0e08fe96f15380aea77ad4a39e93104023ce3

10 years agoMerge "mediawiki.util: Decode parentheses and bang in wikiUrlencode"
jenkins-bot [Fri, 16 May 2014 17:27:54 +0000 (17:27 +0000)]
Merge "mediawiki.util: Decode parentheses and bang in wikiUrlencode"

10 years agoMerge "vector.collapsibleTabs: Rename $settings to settings"
jenkins-bot [Fri, 16 May 2014 16:52:54 +0000 (16:52 +0000)]
Merge "vector.collapsibleTabs: Rename $settings to settings"

10 years agovector.collapsibleTabs: Rename $settings to settings
Timo Tijhof [Fri, 16 May 2014 16:08:59 +0000 (18:08 +0200)]
vector.collapsibleTabs: Rename $settings to settings

This is just a plain object.

Change-Id: I062e2a081e605a002c841ad69fe0dcd90fbee057

10 years agomediawiki.searchSuggest: Adjust font size for all inputs, not just magic ones
Bartosz Dziewoński [Tue, 13 May 2014 22:31:02 +0000 (00:31 +0200)]
mediawiki.searchSuggest: Adjust font size for all inputs, not just magic ones

I have no idea why the fix was limited, this issue affects every single
input on every single page (including ones that are part of MediaWiki
interface itself, not skins, see If4ae687b).

Change-Id: I7a6dfbcced64dbfce5d1ab31201c98a134f72fe9

10 years agomediawiki.searchSuggest: Remove duplicate code
Bartosz Dziewoński [Tue, 13 May 2014 22:25:53 +0000 (00:25 +0200)]
mediawiki.searchSuggest: Remove duplicate code

The 'result' function for skin-provided search box is already provided
above as "generic functionality", repeating it doesn't do anything.

Change-Id: I8693f3dbbfb64ac2816da86759233e3870234d77

10 years agoMerge "Use precise ApiMain/ApiQuery type hints in all API modules"
jenkins-bot [Fri, 16 May 2014 15:42:26 +0000 (15:42 +0000)]
Merge "Use precise ApiMain/ApiQuery type hints in all API modules"

10 years agoMerge "HTMLForm vform styling"
jenkins-bot [Fri, 16 May 2014 15:41:19 +0000 (15:41 +0000)]
Merge "HTMLForm vform styling"

10 years agoHTMLForm vform styling
wctaiwan [Mon, 7 Apr 2014 19:16:45 +0000 (15:16 -0400)]
HTMLForm vform styling

Style <select> like other input fields (full width), and fix the issue
where validation errors partially obfuscate the fields by setting display:
block. Refactor code for styling error boxes and improve documentation.

Bug: 63644
Change-Id: I00a35c932a7e0b91b7b01fc327c0c1b9bae66c78

10 years agoUse precise ApiMain/ApiQuery type hints in all API modules
Thiemo Mättig [Tue, 25 Mar 2014 17:22:11 +0000 (18:22 +0100)]
Use precise ApiMain/ApiQuery type hints in all API modules

Which type is used depends on the ApiModuleManager responsible for
the API module. There are two managers, one in ApiMain and one in
ApiQuery. Both contain a list of API modules they instantiate.
Both use $this as the first parameter in the constructors of the
individual modules. There is no other regular way to instantiate the
modules, so we know the type must either be ApiMain or ApiQuery.

The lists don't intersect.

I would have prefered the naming scheme $mainModule for ApiMain
modules and $queryModule for ApiQuery modules but since this
doesn't add much I left the shorter variable names untouched.

Change-Id: Ie6bf19150f1c9b619655a06a8e051412665e54db

10 years agoMerge "Load shared MediaWiki styles when generating the style guide"
jenkins-bot [Fri, 16 May 2014 14:39:03 +0000 (14:39 +0000)]
Merge "Load shared MediaWiki styles when generating the style guide"

10 years agoLoad shared MediaWiki styles when generating the style guide
Bartosz Dziewoński [Fri, 16 May 2014 14:31:34 +0000 (16:31 +0200)]
Load shared MediaWiki styles when generating the style guide

Among other things it defines styles for .errorbox and friends, which
are showcased in the guide.

Change-Id: I14279400b9aa362d19040e8083032e4e7c1c4ba6

10 years agoUpdate jscs and jshint config
Timo Tijhof [Fri, 16 May 2014 14:07:41 +0000 (16:07 +0200)]
Update jscs and jshint config

Continue specifying our coding style more accurately in jscs,
and phase out more deprecated jshint coding style options.

jshint:
* Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0).
* Remove coding style option "curly" (already covered by jscs).
* Remove coding style option "smarttabs" (already covered by jscs).
* Remove option "regexp".
* Enable new option "freeze" (prohibits changing native prototypes).
  http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze
* Re-order to match http://www.jshint.com/docs/options/

jscs:
* Update to grunt-contrib-jshint v0.4.4 (jscs v1.4.5).
* Format .jscsrc file in a more spacious way and order the
  properties less arbitrarily (using the jscs's readme order).
* Improve rule "requireCurlyBraces": Add more keywords that
    should have their code block wrapped in curly braces.
* Improve rule "requireMultipleVarDecl": Use onevar instead of true.
* Remove rules for "sticky operators", these rules are buggy
    and have been deprecated. Using the SpaceBefore/After rules
    for Unary and Binary operators instead.
* Enable rule "disallowYodaConditions".

Change-Id: I6f385e8860e91d9ef4d1f5abecf517d36af45565

10 years agoMerge "SpecialUnwatchedpages: Ajaxify watch links"
jenkins-bot [Fri, 16 May 2014 07:49:37 +0000 (07:49 +0000)]
Merge "SpecialUnwatchedpages: Ajaxify watch links"

10 years agomediawiki.user.test: Use FakeXHR and clean up
Timo Tijhof [Thu, 8 May 2014 10:32:40 +0000 (12:32 +0200)]
mediawiki.user.test: Use FakeXHR and clean up

The test was quite vague (type array, contain '*') which was
because it made an actual API request and that means the actual
user and wiki configuration influence it, naturally.

Replaced with a mock (also speeds up the test), which lets us
do a more appropiate and strict unit test.

There was also a test for asserting mw.config 'wgUserGroups' and
ApiQueryUserInfo/prop=groups return the same thing. This had to
be removed. Not sure where this would belong (if anywhere). Both
OutputPage and ApiQueryUserInfo get it from User::getEffectiveGroups().

Change-Id: I052ad0b93e8cef7a27f7020411ba4665132675f5

10 years agoSpecialUnwatchedpages: Ajaxify watch links
Eranroz [Mon, 30 Apr 2012 18:58:27 +0000 (21:58 +0300)]
SpecialUnwatchedpages: Ajaxify watch links

Add user friendly handling to watch pages from Special:UnwatchedPages
using ajax. Emits a notification message upon completion of the action
and strikes through the list item.

Bug: 17367
Change-Id: Ie32cc54abb6f888a433f7f18ef5ad747a80d7187

10 years agoRevert "Declare visibility on class properties of includes/parser/"
Ori.livneh [Fri, 16 May 2014 00:48:01 +0000 (00:48 +0000)]
Revert "Declare visibility on class properties of includes/parser/"

See https://bugzilla.wikimedia.org/65375#c4

This reverts commit f359cdf61462782743a87943938ef4cce78b2647.

Bug: 65375
Change-Id: I12a60b5cc52a07a6deabcbf47c7c99cd2faac3c3

10 years agoMerge "mediawiki.api: Add parameter ajaxOptions to postWithToken()"
jenkins-bot [Thu, 15 May 2014 22:32:44 +0000 (22:32 +0000)]
Merge "mediawiki.api: Add parameter ajaxOptions to postWithToken()"

10 years agoMerge "Make validation for page more strict on djvu to take only numbers"
jenkins-bot [Thu, 15 May 2014 21:44:57 +0000 (21:44 +0000)]
Merge "Make validation for page more strict on djvu to take only numbers"

10 years agoMerge "Tweaks to compareParserCache.php"
jenkins-bot [Thu, 15 May 2014 20:59:18 +0000 (20:59 +0000)]
Merge "Tweaks to compareParserCache.php"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 15 May 2014 20:20:52 +0000 (20:20 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I4caa3eef8a82b0d055227684b327bb784c873725

10 years agoMerge "Delete the post-edit cookie using the correct domain"
Robmoen [Thu, 15 May 2014 18:48:47 +0000 (18:48 +0000)]
Merge "Delete the post-edit cookie using the correct domain"

10 years agoMake phpcs-strict pass on includes/ (7/7)
Siebrand Mazeland [Thu, 15 May 2014 15:38:28 +0000 (17:38 +0200)]
Make phpcs-strict pass on includes/ (7/7)

Change-Id: Ia9baaf0b3cdbe1a3c6b50ef8c4fe86fead88f909

10 years agomediawiki.api: Add parameter ajaxOptions to postWithToken()
Fomafix [Thu, 15 May 2014 11:39:03 +0000 (11:39 +0000)]
mediawiki.api: Add parameter ajaxOptions to postWithToken()

This allows to upload a file with token.

var api = new mw.Api();
api.postWithToken(
'edit',
{
action: 'upload',
format: 'json',
filename: 'Foobar.png',
file: file
},
{
contentType: 'multipart/form-data'
}
);

Change-Id: I7a0fec3c1ef2c7881d4c04b1a9dd44fac02cb346

10 years agoMerge "Minor fix to contenthandler.txt doc."
jenkins-bot [Thu, 15 May 2014 17:32:30 +0000 (17:32 +0000)]
Merge "Minor fix to contenthandler.txt doc."

10 years agoSpeed up CIDR matching from $wgSquidServersNoPurge
Brandon Black [Tue, 6 May 2014 18:49:26 +0000 (13:49 -0500)]
Speed up CIDR matching from $wgSquidServersNoPurge

This adds a new generic library class IPSet, which precomputes
a reasonably-efficient data structure from the input list of
addresses and CIDR net/mask specs for fast runtime matching,
and then uses it to check trusted XFF-setters.

See also: 32b4f19f173fc5cff1029eedee63a39a2d72dd3a
Bug: 57021
Change-Id: Ia3b12fb90c3e7e492374a128943b014481cc2730

10 years agoDrop rc_cur_time from recentchanges
umherirrender [Mon, 14 Apr 2014 18:44:22 +0000 (20:44 +0200)]
Drop rc_cur_time from recentchanges

Field was removed in 1.23 from sql statements, but kept to allow easier
rollback on version update from 1.22 -> 1.23, when something gets wrong
with the new version.

Bug: 40667
Follow-Up: I4a9c2fa813d1f25dfb755e564f7677a212934d7b
Change-Id: I48989aceec31019f0b6c98aaeafaf60e975244df