RCFilters UI: Only show full coverage message if item isn't highlighted

Bug: T161273
Change-Id: If62bbab3e12fc3d9e83f9452723a9b2d6b75854a

diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
index a066d9e..221d2a5 100644 (file)
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
@@ -172,7 +172,9 @@
 
                                messageKey = details.message;
                                affectingItems = details.names;
-                       } else if ( this.isIncluded() ) {
+                       } else if ( this.isIncluded() && !this.isHighlighted() ) {
+                               // We only show the 'no effect' full-coverage message
+                               // if the item is also not highlighted. See T161273
                                superset = this.getSuperset();
                                // For this message we need to collect the affecting superset
                                affectingItems = this.getGroupModel().getSelectedItems( this )
@@ -184,7 +186,7 @@
                                        } );
 
                                messageKey = 'rcfilters-state-message-subset';
-                       } else if ( this.isFullyCovered() ) {
+                       } else if ( this.isFullyCovered() && !this.isHighlighted() ) {
                                affectingItems = this.getGroupModel().getSelectedItems( this )
                                        .map( function ( item ) {
                                                return mw.msg( 'quotation-marks', item.getLabel() );