Revert r110045: well-meaning but broken attempt to apply preemptive XSS protection...
authorBrion Vibber <brion@users.mediawiki.org>
Mon, 27 Feb 2012 21:52:33 +0000 (21:52 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Mon, 27 Feb 2012 21:52:33 +0000 (21:52 +0000)
This caused bug 34708: broke usage examples in WikiEditor which include <a href> or <img> tags as-is, which is perfectly legit HTML.

includes/MessageBlobStore.php

index f3fc4d3..be6b27c 100644 (file)
@@ -350,12 +350,7 @@ class MessageBlobStore {
                $messages = array();
 
                foreach ( $module->getMessages() as $key ) {
-                       $messages[$key] =
-                               Sanitizer::normalizeCharReferences(
-                                       Sanitizer::removeHTMLtags(
-                                               wfMsgExt( $key, array( 'language' => $lang ) )
-                                       )
-                               );
+                       $messages[$key] = wfMsgExt( $key, array( 'language' => $lang ) );
                }
 
                return FormatJson::encode( (object)$messages );